Skip to content

Commit 24454e4

Browse files
committed
Use dynamic root id
1 parent 78b3e1f commit 24454e4

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

R/live.R

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,6 @@ LiveHTML <- R6::R6Class(
9191
p <- self$session$Page$loadEventFired(wait_ = FALSE)
9292
self$session$Page$navigate(url, wait_ = FALSE)
9393
self$session$wait_for(p)
94-
95-
private$root_id <- self$session$DOM$getDocument(0)$root$nodeId
9694
},
9795

9896
#' @description Called when `print()`ed
@@ -202,7 +200,7 @@ LiveHTML <- R6::R6Class(
202200

203201
# https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollTo
204202
private$call_node_method(
205-
private$root_id,
203+
private$root_id(),
206204
paste0(".documentElement.scrollTo(", left, ", ", top, ")")
207205
)
208206
invisible(self)
@@ -262,8 +260,9 @@ LiveHTML <- R6::R6Class(
262260
),
263261

264262
private = list(
265-
root_id = NULL,
266-
263+
root_id = function() {
264+
self$session$DOM$getDocument()$root$nodeId
265+
},
267266
finalize = function() {
268267
self$session$close()
269268
},
@@ -272,7 +271,6 @@ LiveHTML <- R6::R6Class(
272271
if (new_chromote && !self$session$is_active()) {
273272
suppressMessages({
274273
self$session <- self$session$respawn()
275-
private$root_id <- self$session$DOM$getDocument(0)$root$nodeId
276274
})
277275
}
278276
},
@@ -293,7 +291,7 @@ LiveHTML <- R6::R6Class(
293291
find_nodes = function(css, xpath) {
294292
check_exclusive(css, xpath)
295293
if (!missing(css)) {
296-
unlist(self$session$DOM$querySelectorAll(private$root_id, css)$nodeIds)
294+
unlist(self$session$DOM$querySelectorAll(private$root_id(), css)$nodeIds)
297295
} else {
298296
search <- glue::glue("
299297
(function() {{

0 commit comments

Comments
 (0)