Skip to content

Commit 4ea87ed

Browse files
hadleyhadley
committed
Prepare for release
1 parent f40d928 commit 4ea87ed

5 files changed

Lines changed: 42 additions & 117 deletions

File tree

‎DESCRIPTION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Package: rvest
2-
Version: 0.3.0.9000
2+
Version: 0.3.1
33
Title: Easily Harvest (Scrape) Web Pages
44
Description: Wrappers around the 'xml2' and 'httr' packages to make it easy to
55
download, then manipulate, HTML and XML.

‎NEWS.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
# rvest 0.3.0.9000
1+
# rvest 0.3.1
2+
3+
* Fix invalid link for SSA example.
24

35
* Parse `<options>` that don't have value attribute (#85).
46

‎R/session.R‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ print.history <- function(x, ...) {
181181
# html methods -----------------------------------------------------------------
182182

183183
#' @export
184-
html_form.session <- function(x) html_form(read_html(x))
184+
html_form.session <- function(x) html_form(xml2::read_html(x))
185185

186186
#' @export
187187
html_table.session <- function(x, header = NA, trim = TRUE, fill = FALSE,

‎cran-comments.md‎

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,26 @@
11
## Submission summary
22

3-
This is a major rewrite which replaces use of the XML package with xml2 (thus avoiding many memory leaks). This is a large change, so I gave the downstream maintainers plenty of time to respond.
3+
* Fixes failing url in examples.
4+
* Also includes two minor bug fixes.
45

56
## Test environments
67

7-
* local OS X install, R 3.1.2
8-
* ubuntu 12.04 (on travis-ci), R 3.1.2
8+
* local OS X install, R 3.2.1
9+
* ubuntu 12.04 (on travis-ci), R 3.2.2
910
* win-builder (devel and release)
1011

1112
## R CMD check results
12-
1313
There were no ERRORs or WARNINGs.
1414

15-
There was 1 NOTE:
16-
17-
* I have changed the maintainer address to hadley@rstudio.com. I'll send
18-
a confirmation from my old address shortly.
15+
There was one NOTE:
1916

20-
* There was a false positive for "found the following (possibly) invalid URLs":
21-
the vignette includes a javascript bookmarklet which starts with
22-
`javascript:`.
17+
* "Found the following (possibly) invalid URLs: URL: javascript:(...)" -
18+
this is a false positive. It's a valid used to embed a JS bookmarklet in
19+
a vignette.
2320

2421
## Downstream dependencies
2522

26-
* I ran R CMD check on all 7 downstream dependencies. (Summary at
23+
* I ran R CMD check on all 9 downstream dependencies. (Summary at
2724
https://github.com/hadley/rvest/blob/master/revdep/summary.md)
2825

29-
* There are three new failures:
30-
31-
* gsheet, nhanesA: uses deprecated function
32-
* wikipediatrend: uses deprecated function, test now fails
33-
34-
* I notified all downstream maintainers on Sep 2 that release would happen on
35-
Sep 22. I notified them again today.
26+
* There were no new failures

‎revdep/summary.md‎

Lines changed: 27 additions & 95 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,28 @@
66
|:--------|:----------------------------|
77
|version |R version 3.2.1 (2015-06-18) |
88
|system |x86_64, darwin13.4.0 |
9-
|ui |RStudio (0.99.674) |
9+
|ui |RStudio (0.99.747) |
1010
|language |(EN) |
1111
|collate |en_US.UTF-8 |
1212
|tz |America/Chicago |
13-
|date |2015-09-22 |
13+
|date |2015-11-06 |
1414

1515
## Packages
1616

17-
|package |* |version |date |source |
18-
|:--------|:--|:-------|:----------|:--------------|
19-
|httr | |1.0.0 |2015-06-25 |CRAN (R 3.2.0) |
20-
|knitr | |1.10.5 |2015-05-06 |CRAN (R 3.2.0) |
21-
|magrittr | |1.5 |2014-11-22 |CRAN (R 3.2.0) |
22-
|png | |0.1-7 |2013-12-03 |CRAN (R 3.2.0) |
23-
|selectr | |0.2-3 |2014-12-24 |CRAN (R 3.2.0) |
24-
|stringi | |0.5-5 |2015-06-29 |CRAN (R 3.2.0) |
25-
|testthat |* |0.10.0 |2015-05-22 |CRAN (R 3.2.0) |
26-
|xml2 | |0.1.2 |2015-09-01 |CRAN (R 3.2.0) |
17+
|package |* |version |date |source |
18+
|:---------|:--|:-------|:----------|:--------------|
19+
|httr | |1.0.0 |2015-06-25 |CRAN (R 3.2.0) |
20+
|knitr | |1.10.5 |2015-05-06 |CRAN (R 3.2.0) |
21+
|magrittr | |1.5 |2014-11-22 |CRAN (R 3.2.0) |
22+
|png | |0.1-7 |2013-12-03 |CRAN (R 3.2.0) |
23+
|rmarkdown | |0.7 |2015-06-13 |CRAN (R 3.2.0) |
24+
|selectr | |0.2-3 |2014-12-24 |CRAN (R 3.2.0) |
25+
|stringi | |1.0-1 |2015-10-22 |CRAN (R 3.2.0) |
26+
|testthat |* |0.11.0 |2015-10-14 |CRAN (R 3.2.0) |
27+
|xml2 | |0.1.2 |2015-09-01 |CRAN (R 3.2.0) |
2728

2829
# Check results
29-
7 checked out of 7 dependencies
30+
8 checked out of 9 dependencies
3031

3132
## gsheet (0.1.0)
3233
Maintainer: Max Conway <conway.max1@gmail.com>
@@ -53,36 +54,20 @@ Maintainer: Jonathan Callahan <jonathan.s.callahan@gmail.com>
5354

5455
__OK__
5556

56-
## nhanesA (0.5)
57+
## nhanesA (0.6.1)
5758
Maintainer: Christopher Endres <cjendres1@gmail.com>
5859

59-
```
60-
checking examples ... WARNING
61-
Found the following significant warnings:
62-
63-
Warning: 'html' is deprecated.
64-
Warning: 'html' is deprecated.
65-
Warning: 'html' is deprecated.
66-
Warning: 'html' is deprecated.
67-
Warning: 'html' is deprecated.
68-
Warning: 'html' is deprecated.
69-
Deprecated functions may be defunct as soon as of the next release of
70-
R.
71-
See ?Deprecated.
72-
```
73-
```
74-
DONE
75-
Status: 1 WARNING
76-
```
60+
__OK__
7761

7862
## rex (1.0.1)
7963
Maintainer: Jim Hester <james.f.hester@gmail.com>
8064
Bug reports: https://github.com/kevinushey/rex/issues
8165

8266
__OK__
8367

84-
## rNOMADS (2.1.4)
85-
Maintainer: Daniel C. Bowman <daniel.bowman@unc.edu>
68+
## rscopus (0.1.2)
69+
Maintainer: John Muschelli <muschellij2@gmail.com>
70+
Bug reports: https://github.com/muschellij2/rscopus/issues
8671

8772
__OK__
8873

@@ -92,76 +77,23 @@ Bug reports: https://github.com/trulia/choroplethr/issues
9277

9378
__OK__
9479

95-
## wikipediatrend (1.1.6)
80+
## sejmRP (1.2)
81+
Maintainer: Piotr Smuda <piotrsmuda@gmail.com>
82+
Bug reports: http://github.com/mi2-warsaw/sejmRP/issues
83+
84+
__OK__
85+
86+
## wikipediatrend (1.1.7)
9687
Maintainer: Peter Meissner <retep.meissner@gmail.com>
9788
Bug reports: https://github.com/petermeissner/wikipediatrend/issues
9889

9990
```
10091
checking package dependencies ... NOTE
10192
Packages suggested but not available for checking:
10293
‘AnomalyDetection’ ‘BreakoutDetection’
103-
```
104-
```
105-
checking examples ... WARNING
106-
Found the following significant warnings:
107-
108-
Warning: 'rvest::html' is deprecated.
109-
Warning: 'rvest::html' is deprecated.
110-
Deprecated functions may be defunct as soon as of the next release of
111-
R.
112-
See ?Deprecated.
113-
```
114-
```
115-
checking tests ... ERROR
116-
Running the tests in ‘tests/testthat.R’ failed.
117-
Last 13 lines of output:
118-
11: Ops.data.frame(dings, dongs)
119-
12: matrix(unlist(value, recursive = FALSE, use.names = FALSE), nrow = nr, dimnames = list(rn,
120-
cn))
121-
122-
Error : expecting a single value
123-
testthat results ================================================================
124-
OK: 63 SKIPPED: 0 FAILED: 3
125-
1. Failure (at test_caching_gathering.R#27): normal usage
126-
2. Failure (at test_caching_gathering.R#39): setting cache file
127-
3. Error: cache reset
128-
129-
Error: testthat unit tests failed
130-
Execution halted
131-
```
132-
```
133-
checking re-building of vignette outputs ... NOTE
134-
Error in re-building vignettes:
135-
...
136-
http://stats.grok.se/json/en/201508/Millennium_Development_Goals
137-
Error in eval(expr, envir, enclos) : expecting a single value
138-
http://stats.grok.se/json/es/201506/Objetivos_de_Desarrollo_del_Milenio
139-
Error in eval(expr, envir, enclos) : expecting a single value
140-
http://stats.grok.se/json/es/201507/Objetivos_de_Desarrollo_del_Milenio
141-
Error in eval(expr, envir, enclos) : expecting a single value
142-
http://stats.grok.se/json/es/201508/Objetivos_de_Desarrollo_del_Milenio
143-
Error in eval(expr, envir, enclos) : expecting a single value
144-
http://stats.grok.se/json/en/201506/Millennium_Development_Goals
145-
Error in eval(expr, envir, enclos) : expecting a single value
146-
http://stats.grok.se/json/en/201507/Millennium_Development_Goals
147-
Error in eval(expr, envir, enclos) : expecting a single value
148-
http://stats.grok.se/json/en/201508/Millennium_Development_Goals
149-
Error in eval(expr, envir, enclos) : expecting a single value
150-
http://stats.grok.se/json/en/201508/Cheese
151-
Error in eval(expr, envir, enclos) : expecting a single value
152-
http://stats.grok.se/json/de/201508/K%C3%A4se
153-
Error in eval(expr, envir, enclos) : expecting a single value
154-
Error in eval(expr, envir, enclos) : expecting a single value
155-
Error in eval(expr, envir, enclos) : expecting a single value
156-
Error in eval(expr, envir, enclos) : expecting a single value
157-
Quitting from lines 286-289 (using-wikipediatrend.Rmd)
158-
Error: processing vignette 'using-wikipediatrend.Rmd' failed with diagnostics:
159-
expecting a single value
160-
Execution halted
161-
16294
```
16395
```
16496
DONE
165-
Status: 1 ERROR, 1 WARNING, 2 NOTEs
97+
Status: 1 NOTE
16698
```
16799

0 commit comments

Comments
 (0)