Fix R CMD check and misc cleanups#445
Merged
Merged
Conversation
shikokuchuo
force-pushed
the
fix-checks
branch
from
b3e23a6 to
e16b696
Compare
shikokuchuo
commented
Aug 20, 2025
shikokuchuo
left a comment
shikokuchuo
left a comment
Member
Author
There was a problem hiding this comment.
@hadley this turned into a mini-upkeep to get this to check cleanly on CI. Tagging you as I can't seem to directly request a review.
jonthegeek
added a commit
to jonthegeek/rvest
that referenced
this pull request
Aug 20, 2025
This won't pass checks until tidyverse#445 is merged, but this particular new test passes and should prevent regressions of this particular use case.
shikokuchuo
pushed a commit
to shikokuchuo/rvest
that referenced
this pull request
Aug 20, 2025
This won't pass checks until tidyverse#445 is merged, but this particular new test passes and should prevent regressions of this particular use case.
Member
|
Thank you! |
shikokuchuo
pushed a commit
to shikokuchuo/rvest
that referenced
this pull request
Aug 20, 2025
This won't pass checks until tidyverse#445 is merged, but this particular new test passes and should prevent regressions of this particular use case.
shikokuchuo
pushed a commit
to shikokuchuo/rvest
that referenced
this pull request
Aug 20, 2025
This won't pass checks until tidyverse#445 is merged, but this particular new test passes and should prevent regressions of this particular use case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #444. Closes #442.