resolving comments

Author: markoj2207

contracts/libraries/vortex-lper/README.md

@@ -20,19 +20,19 @@ pub struct LibraryConfig {
 }
 
 pub struct LiquidityProviderConfig {
-    // Code of the vortex contract we are going to instantiate
+    /// Code of the vortex contract we are going to instantiate
     pub vortex_code: u64,
-    // Label for the contract instantiation
+    /// Label for the contract instantiation
     pub label: String,
-    // Id of the pool we are going to provide liquidity for
+    /// Id of the pool we are going to provide liquidity for
     pub pool_id: u64,
-    // Duration of the round in seconds
+    /// Duration of the round in seconds
     pub round_duration: u64,
-    // Duration of the auction in seconds
+    /// Duration of the auction in seconds
     pub auction_duration: u64,
-    // Denoms of both assets we are going to provide liquidity for
+    /// Denoms of both assets we are going to provide liquidity for
     pub asset_data: AssetData,
-    // Whether the principal token is first in the pool
+    /// Whether the principal token is first in the pool
     pub principal_first: bool,
 }
 ```

contracts/libraries/vortex-lper/src/contract.rs

@@ -11,7 +11,6 @@ use valence_library_utils::{
     msg::{ExecuteMsg, InstantiateMsg},
 };
 use valence_osmosis_utils::utils::cl_utils::query_cl_pool;
-use valence_vortex_utils::msg::CreatePositionMsg;
 
 use crate::{
     msg::{Config, FunctionMsgs, LibraryConfig, LibraryConfigUpdate, QueryMsg, ReplyPayload},
@@ -188,22 +187,14 @@ pub fn reply(deps: DepsMut, _env: Env, msg: Reply) -> Result<Response, LibraryEr
                     StdError::generic_err(format!("failed to parse reply message: {e:?}"))
                 })?;
 
-            let create_position_msg: CreatePositionMsg = reply_payload.create_position_msg;
-
             VORTEX_CONTRACT_ADDR.save(
                 deps.storage,
                 &instantiate_msg_response.contract_address.clone(),
             )?;
 
-            let create_position_msg = valence_vortex_utils::msg::CreatePositionMsg {
-                lower_tick: create_position_msg.lower_tick,
-                upper_tick: create_position_msg.upper_tick,
-                principal_token_min_amount: create_position_msg.principal_token_min_amount,
-                counterparty_token_min_amount: create_position_msg.counterparty_token_min_amount,
-            };
-
-            let execute_msg =
-                valence_vortex_utils::msg::ExecuteMsg::CreatePosition(create_position_msg);
+            let execute_msg = valence_vortex_utils::msg::ExecuteMsg::CreatePosition(
+                reply_payload.create_position_msg,
+            );
 
             let bal_asset_0 = deps
                 .querier

docs/src/libraries/cosmwasm/vortex_lper.md

@@ -26,7 +26,7 @@ graph LR
 
 | Function | Parameters | Description |
 |----------|------------|-------------|
-| **ProvideLiquidity** | `tick_range: TickRange`<br>`token_min_amount_0: Uint128`<br>`token_min_amount_1: Uint128` | tries to deposit the  entire principal and counterparty token amounts from the input account to the pool via Vortex. |
+| **ProvideLiquidity** | `tick_range: TickRange`<br>`principal_token_min_amount: Uint128`<br>`counterparty_token_min_amount: Uint128` | tries to deposit the  entire principal and counterparty token amounts from the input account to the pool via Vortex. |
 | **Withdraw** | - | withdraws all the liquidity from the position Vortex entered including potential rewards. |
 
 ## Configuration
@@ -39,27 +39,27 @@ pub struct LibraryConfig {
     pub input_addr: LibraryAccountType,
     /// Address of the output account 
     pub output_addr: LibraryAccountType,
-     /// Address of the second output account 
+    /// Address of the second output account 
     pub output_addr_2: LibraryAccountType,
     /// Configuration for the liquidity provider
     /// This includes the pool address and asset data
     pub lp_config: LiquidityProviderConfig,
 }
 
 pub struct LiquidityProviderConfig {
-    // Code of the vortex contract we are going to instantiate
+    /// Code of the vortex contract we are going to instantiate
     pub vortex_code: u64,
-    // Label for the contract instantiation
+    /// Label for the contract instantiation
     pub label: String,
-    // Id of the pool we are going to provide liquidity for
+    /// Id of the pool we are going to provide liquidity for
     pub pool_id: u64,
-    // Duration of the round in seconds
+    /// Duration of the round in seconds
     pub round_duration: u64,
-    // Duration of the auction in seconds
+    /// Duration of the auction in seconds
     pub auction_duration: u64,
-    // Denoms of both assets we are going to provide liquidity for
+    /// Denoms of both assets we are going to provide liquidity for
     pub asset_data: AssetData,
-    // Whether the principal token is first in the pool
+    /// Whether the principal token is first in the pool
     pub principal_first: bool,
 }
 ```
@@ -69,7 +69,9 @@ pub struct LiquidityProviderConfig {
 ### Providing Liquidity Process
 
 1. **Balance Check**: Queries the input account balance for the specified pool assets.
-2. **ProvideLiquidity**: Executes a `CreatePosition` message to the Vortex contract making Vortex to create a position in the Osmosis pool.
+2. **ProvideLiquidity**: Initiates the liquidity process by executing a `CreatePosition` submessage to the Vortex contract.  
+   - The initial call **instantiates the Vortex contract**.  
+   - Once the submessage completes, the **reply handler** performs the actual position creation in the Osmosis pool by the Vortex contract instance. 
 
 ### Withdrawal Process