Update code sniffer, code coverage, and more

[milesj]

While these projects aren't directly a part of the framework, they would be nice to use on/in the codebase.

If possible, we should add HHVM/Hack support to the following projects:

• CS Fixer - https://github.com/FriendsOfPHP/PHP-CS-Fixer
• Code Sniffer - https://github.com/squizlabs/PHP_CodeSniffer
• Code Coverage - https://github.com/sebastianbergmann/php-code-coverage
• Mess Detector - http://phpmd.org/

[GrahamCampbell]

I don't see that ever happening. PHP-CS-Fixer is a code base I know quite well, and it's already pretty complex.

[milesj]

That's unfortunate. I'm sure the built-in type checker will cover most use cases regardless.

I'm mostly interested in the CS fixer so that our syntax stays consistent.

[milesj]

Tried testing CS fixer to see what would happen. The code ran without errors but it didn't actually fix anything. Not surprising.

I'll spend some more time on this and see what exactly is going on.

[GrahamCampbell]

The code ran without errors but it didn't actually fix anything. Not surprising.

That's because it's tokenizing the code. Because there's no opening PHP tags, then the file is treated as html by php.

[GrahamCampbell]

I say, html, but you know what I mean. :)

[milesj]

Yeah I figured it was something like that. I'm just curious how different Hack's token_get_all() is compared to PHP's.

[GrahamCampbell]

Were you running php-cs-fixer on hack? If so, it looks like the tokenizer exposed on hack still behaves like the php one, which sucks. I barely use hack, so am not really familiar with it.

[milesj]

I was running php-cs-fixer through HHVM on Hack files. But yeah, haven't dug into it deeper yet.