Skip to content

Commit be240db

Browse files
committed
Un-hardcode officer names
- Use site preferences for officer names - There is no way update the names directly besides using the following line while debugging the app: ``` quip.apps.getSitePreferences().save({officers: { president: 'President', vpm: 'Vice President of Membership', vpe: 'Vice President of Education', vppr: 'Vice President of Public Relations', secretary: 'Secretary', soa: 'Sergeant of Arms', treasurer: 'Treasurer', }}) ``` Fixes #12.
1 parent 0b9d0cd commit be240db

2 files changed

Lines changed: 3 additions & 13 deletions

File tree

app/manifest.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"manifest_version": 4,
44
"name": "Toastmasters Agenda",
55
"disable_app_level_comments": false,
6-
"version_name": "2.1.2",
7-
"version_number": 21,
6+
"version_name": "2.1.3",
7+
"version_number": 22,
88
"sizing_mode": "fill_container",
99
"initial_height": 300,
1010
"initial_width": 300,

src/utils/print-and-save.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,7 @@ function getPrintAgendaData() {
8888
data: {
8989
date:
9090
getRichTextRecordContent(rootRecord.get('date').get('value')),
91-
// TODO (#12): Use site preferences to store officer names instead
92-
// of hard-coding.
93-
officers: {
94-
president: 'KC Lakshminarasimham',
95-
vpm: 'Anny He',
96-
vpe: 'Srinath Krishna Ananthakrishnan',
97-
vppr: 'Max Kukartsev',
98-
secretary: 'Rosaura Arevalo',
99-
soa: 'Jack Faraday',
100-
treasurer: 'Ron Sison',
101-
},
91+
officers: quip.apps.getSitePreferences().getForKey('officers'),
10292
items,
10393
},
10494
};

0 commit comments

Comments
 (0)