Hi - thanks for working on Vidaa TV control. I'm the author of myhisense-tv (https://github.com/warrenrees/myhisense-tv) (PyPI: myhisense-tv), first published 2025-12-31.
vidaa-control appears to be derived directly from that project: the package layout (vidaa/ -> hisense_tv/, vidaa2mqtt/ -> hisense2mqtt/), the modules, and the reverse-engineered credential algorithm are the same.
For example vidaa/credentials.py is identical to my hisense_tv/credentials.py - same generate_credentials logic, and the same comments (e.g. "UUID should keep original case - the race hash is case-sensitive!"). vidaa/config/constants.py differs only by one docstring word.
That's totally fine under my MIT license - reuse and building on it is welcome.
The license only asks for one thing: that the original copyright and permission notice be retained in copies ("The above copyright notice
… shall be included in all copies or substantial portions of the Software.").
Right now LICENSE reads Copyright (c) 2025 Tom Babolewski with my notice removed, and there's no attribution in the README or pyproject.toml.
Could you please:
- Restore the original MIT notice in LICENSE (Copyright (c) 2024 Warren Rees) — keeping your own copyright alongside it is fine for your modifications; and
- Add a line to the README crediting the upstream project (warrenrees/myhisense-tv).
Happy to help - I think the projects can coexist, I'd just like the attribution the license requires.
Thanks!
Warren
Hi - thanks for working on Vidaa TV control. I'm the author of myhisense-tv (https://github.com/warrenrees/myhisense-tv) (PyPI: myhisense-tv), first published 2025-12-31.
vidaa-control appears to be derived directly from that project: the package layout (vidaa/ -> hisense_tv/, vidaa2mqtt/ -> hisense2mqtt/), the modules, and the reverse-engineered credential algorithm are the same.
For example vidaa/credentials.py is identical to my hisense_tv/credentials.py - same generate_credentials logic, and the same comments (e.g. "UUID should keep original case - the race hash is case-sensitive!"). vidaa/config/constants.py differs only by one docstring word.
That's totally fine under my MIT license - reuse and building on it is welcome.
The license only asks for one thing: that the original copyright and permission notice be retained in copies ("The above copyright notice
… shall be included in all copies or substantial portions of the Software.").
Right now LICENSE reads Copyright (c) 2025 Tom Babolewski with my notice removed, and there's no attribution in the README or pyproject.toml.
Could you please:
Happy to help - I think the projects can coexist, I'd just like the attribution the license requires.
Thanks!
Warren