fix regression with main entities translation

Author: tomer-w

custom_components/victron_mqtt/entity.py

@@ -45,14 +45,14 @@ def __init__(
             self.entity_id = entity_id
         self._attr_unique_id = entity_id
         self._attr_suggested_display_precision = metric.precision
-        # When main_topic is set, omit translation_key/name so HA uses the device name (via _attr_has_entity_name).
+        # Always set translation_key so HA can resolve state/option translations (e.g. select options).
+        self._attr_translation_key = metric.generic_short_id.replace(
+            "{", ""
+        ).replace("}", "")
+        self._attr_translation_placeholders = metric.key_values
+        # When main_topic is set, override name to None so HA uses the device name (via _attr_has_entity_name).
         if metric.main_topic:
             self._attr_name = None
-        else:
-            self._attr_translation_key = metric.generic_short_id.replace(
-                "{", ""
-            ).replace("}", "")
-            self._attr_translation_placeholders = metric.key_values
 
         # Special case for "%" as it should not be coming from the localization file
         self._attr_native_unit_of_measurement = (

tests/test_hub.py

@@ -447,9 +447,13 @@ async def test_device_tracker(
     """Test device tracker entity creation from GPS location."""
     victron_hub, mock_config_entry = init_integration
 
-    # Inject GPS coordinates (latitude and longitude)
+    # Inject all GPS metrics required by the gps_location formula
     await inject_message(victron_hub, "N/123/gps/0/Position/Latitude", '{"value": 52.3676}')
     await inject_message(victron_hub, "N/123/gps/0/Position/Longitude", '{"value": 4.9041}')
+    await inject_message(victron_hub, "N/123/gps/0/Fix", '{"value": 1}')
+    await inject_message(victron_hub, "N/123/gps/0/Altitude", '{"value": 10.0}')
+    await inject_message(victron_hub, "N/123/gps/0/Course", '{"value": 0.0}')
+    await inject_message(victron_hub, "N/123/gps/0/Speed", '{"value": 0.0}')
     await finalize_injection(victron_hub)
 
     # Verify entity was created by checking entity registry
@@ -472,6 +476,10 @@ async def test_device_tracker_update(
 
     await inject_message(victron_hub, "N/123/gps/0/Position/Latitude", '{"value": 52.3676}')
     await inject_message(victron_hub, "N/123/gps/0/Position/Longitude", '{"value": 4.9041}')
+    await inject_message(victron_hub, "N/123/gps/0/Fix", '{"value": 1}')
+    await inject_message(victron_hub, "N/123/gps/0/Altitude", '{"value": 10.0}')
+    await inject_message(victron_hub, "N/123/gps/0/Course", '{"value": 0.0}')
+    await inject_message(victron_hub, "N/123/gps/0/Speed", '{"value": 0.0}')
     await finalize_injection(victron_hub, disconnect=False)
     await hass.async_block_till_done()