Skip to content

Commit ac4834a

Browse files
committed
Fix leftover connect_max_failed_attempts from SSDP refactor
1 parent 55d5ed5 commit ac4834a

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

custom_components/victron_mqtt/config_flow.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,7 @@ def default_port_for(use_ssl: bool) -> int:
134134
)
135135

136136

137-
async def validate_input(
138-
data: dict[str, Any],
139-
connect_max_failed_attempts: int = 3,
140-
) -> str:
137+
async def validate_input(data: dict[str, Any]) -> str:
141138
"""Validate the user input allows us to connect.
142139
143140
Data has the keys from zeroconf values as well as user input.
@@ -153,7 +150,6 @@ async def validate_input(
153150
username=data.get(CONF_USERNAME) or None,
154151
password=data.get(CONF_PASSWORD) or None,
155152
use_ssl=data.get(CONF_SSL, False),
156-
connect_max_failed_attempts=connect_max_failed_attempts,
157153
installation_id=data.get(CONF_INSTALLATION_ID) or None,
158154
serial=data.get(CONF_SERIAL, "noserial"),
159155
topic_prefix=data.get(CONF_ROOT_TOPIC_PREFIX) or None,
@@ -352,7 +348,7 @@ async def async_step_ssdp_confirm(
352348
CONF_SIMPLE_NAMING: DEFAULT_SIMPLE_NAMING,
353349
}
354350
try:
355-
await validate_input(data, connect_max_failed_attempts=1)
351+
await validate_input(data)
356352
except AuthenticationError:
357353
return await self.async_step_ssdp_auth()
358354
except CannotConnectError:
@@ -413,7 +409,7 @@ async def async_step_ssdp_auth(
413409
}
414410

415411
try:
416-
await validate_input(data, connect_max_failed_attempts=1)
412+
await validate_input(data)
417413
except AuthenticationError:
418414
errors["base"] = "invalid_auth"
419415
except CannotConnectError:

tests/test_config_flow.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,6 @@ async def test_ssdp_flow_cannot_connect(
321321

322322
assert result["type"] is FlowResultType.ABORT
323323
assert result["reason"] == "cannot_connect"
324-
assert mock_victron_hub.call_args.kwargs["connect_max_failed_attempts"] == 1
325324

326325

327326
@pytest.mark.usefixtures("mock_victron_hub")

0 commit comments

Comments
 (0)