Commit 8910f6e
committed
PM-5221: include Data Science Challenge winners
What was broken
The completion rerate endpoint only added ChallengeWinner placement participants for Development Challenge ratings. A Data Science Challenge winner without a review-api challengeResult row was never passed to the rating replay, so no DATA_SCIENCE / Challenge rating or history row was created for that profile.
Root cause (if identifiable)
The previous PM-5221 fix added Data Science Challenge rating jobs and Data Science rating dimensions, but participant discovery for DATA_SCIENCE_CHALLENGE still returned only challengeResult submitters while DEVELOPMENT_CHALLENGE also appended ChallengeWinner placement ids.
What was changed
Data Science Challenge participant discovery now includes ChallengeWinner placement ids using the existing winner fallback and de-duplication path, matching the Development Challenge behavior.
Any added/updated tests
Added unit coverage for rerating Data Science Challenge winners when challengeResult rows are absent.1 parent 045c2ad commit 8910f6e
2 files changed
Lines changed: 75 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
602 | 602 | | |
603 | 603 | | |
604 | 604 | | |
605 | | - | |
606 | | - | |
607 | | - | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
608 | 609 | | |
609 | 610 | | |
610 | 611 | | |
| |||
613 | 614 | | |
614 | 615 | | |
615 | 616 | | |
616 | | - | |
| 617 | + | |
617 | 618 | | |
618 | 619 | | |
619 | 620 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
943 | 943 | | |
944 | 944 | | |
945 | 945 | | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
946 | 1016 | | |
947 | 1017 | | |
948 | 1018 | | |
| |||
0 commit comments