Fix for wrong counts on history on profile

Author: jmgasper

src/services/StatisticsService.js

@@ -1811,32 +1811,25 @@ function dedupeUnifiedHistoryRows (rows) {
 }
 
 /**
- * Remove empty imported Marathon Match rows that still reference unmapped numeric
+ * Remove imported Marathon Match rows that still reference unmapped numeric
  * legacy challenge ids.
  *
- * Older Marathon Match histories can predate challenge-api metadata while still
- * carrying rating, placement, or percentile data from the members schema. Those
- * rows are part of the member's rating timeline and must remain visible even
- * when a challenge title cannot be resolved.
+ * Resolved legacy ids are canonicalized before this point. Any remaining
+ * numeric MM challenge id cannot be matched to challenge-api metadata, so it is
+ * ignored to avoid surfacing stale legacy rating rows or double-counting history.
  *
  * @param {Array<Object>} rows persisted and/or transient history rows
- * @returns {Array<Object>} history rows without empty unresolved legacy MM entries
+ * @returns {Array<Object>} history rows without unresolved legacy MM entries
  */
-function filterEmptyUnresolvedLegacyMarathonHistoryRows (rows) {
+function filterUnresolvedLegacyMarathonHistoryRows (rows) {
   return _.filter(rows || [], (row) => {
     const challengeId = normalizeChallengeLookupKey(row && row.challengeId)
     const isLegacyNumericChallenge = challengeId && /^\d+$/.test(challengeId)
     const isMarathonHistory = row &&
       row.trackName === TRACK_NAMES.DATA_SCIENCE &&
       row.typeName === TYPE_NAMES.MARATHON_MATCH
-    const hasHistoryData = !_.isNil(row.newRating) ||
-      !_.isNil(row.oldRating) ||
-      !_.isNil(row.placement) ||
-      !_.isNil(row.percentile) ||
-      !_.isNil(row.newVolatility) ||
-      !_.isNil(row.oldVolatility)
-
-    return !(isMarathonHistory && isLegacyNumericChallenge && !row.challengeName && !hasHistoryData)
+
+    return !(isMarathonHistory && isLegacyNumericChallenge && !row.challengeName)
   })
 }
 
@@ -2713,7 +2706,7 @@ async function getHistoryStats (currentUser, handle, query) {
         unresolvedPairKeys = getUnresolvedHistoryPairKeys(unresolvedPairKeys, legacyCodeFallbackRows)
       }
 
-      annotatedRows = filterEmptyUnresolvedLegacyMarathonHistoryRows(annotatedRows)
+      annotatedRows = filterUnresolvedLegacyMarathonHistoryRows(annotatedRows)
 
       const orderedRows = orderUnifiedHistoryRows(recomputeUnifiedHistoryMostRecentFlags(annotatedRows))
       if (orderedRows.length > 0) {

test/unit/StatisticsService.test.js

@@ -1542,10 +1542,9 @@ describe('statistics service unit tests', () => {
     }
   })
 
-  it('getHistoryStats should preserve data-bearing unresolved legacy numeric Marathon Match rows', async () => {
+  it('getHistoryStats should drop unresolved legacy numeric Marathon Match rows', async () => {
     const ratingDate = new Date('2025-08-27T17:05:00.000Z')
     const legacyDate = new Date('2014-04-18T00:00:00.000Z')
-    const emptyLegacyDate = new Date('2013-04-18T00:00:00.000Z')
     const challenge = {
       id: 'mm-challenge-uuid',
       legacyId: null,
@@ -1578,10 +1577,11 @@ describe('statistics service unit tests', () => {
             newRating: 2946,
             mostRecent: true
           }, {
-            trackId: 'track-ds-id',
+            trackId: 'track-dev-id',
             typeId: 'type-mm-id',
-            challengeId: '15949',
-            eventDate: emptyLegacyDate,
+            challengeId: 'mm-challenge-uuid',
+            challengeName: 'Marathon Match 163',
+            eventDate: ratingDate,
             mostRecent: false
           }, {
             trackId: 'track-ds-id',
@@ -1605,13 +1605,11 @@ describe('statistics service unit tests', () => {
 
       result.should.have.length(1)
       should.exist(result[0].DATA_SCIENCE)
-      result[0].DATA_SCIENCE.MARATHON_MATCH.history.should.have.length(2)
+      result[0].DATA_SCIENCE.MARATHON_MATCH.history.should.have.length(1)
       result[0].DATA_SCIENCE.MARATHON_MATCH.history[0].challengeId.should.equal('mm-challenge-uuid')
       result[0].DATA_SCIENCE.MARATHON_MATCH.history[0].challengeName.should.equal('Marathon Match 163')
+      result[0].DATA_SCIENCE.MARATHON_MATCH.history[0].rating.should.equal(2739)
       result[0].DATA_SCIENCE.MARATHON_MATCH.history[0].mostRecent.should.equal(true)
-      result[0].DATA_SCIENCE.MARATHON_MATCH.history[1].challengeId.should.equal(15948)
-      result[0].DATA_SCIENCE.MARATHON_MATCH.history[1].rating.should.equal(2946)
-      result[0].DATA_SCIENCE.MARATHON_MATCH.history[1].mostRecent.should.equal(false)
     } finally {
       restore()
     }