PM-4151: guard MM provisional review fallback

What was broken
The previous PM-4151 follow-up blocked failed/deleted Marathon Match submissions and guarded final score fallback, but a failed provisional review row could still leak stale score data. If the latest provisional review summation had a negative score, the SQL filtered that row out before fallback logic and then used submission.initialScore or an older positive provisional row.

Root cause
The provisional review lateral queries only selected non-negative reviewSummation rows, so the CASE expression could not distinguish no provisional review from a latest failed provisional review. The final score path already had a has_final_review guard, but the provisional score path did not have the same guard.

What was changed
Added a has_provisional_review guard to submitter, valid submitter, and winner exports. The reports now use the latest provisional review row, return the score only when that row is non-negative, and only fall back to submission.initialScore when no provisional review row exists.

Any added/updated tests
Updated src/reports/challenges/challenge-export-sql.spec.ts to assert the provisional review guard and prevent pre-filtering negative provisional review rows before fallback logic runs.

Author: jmgasper

sql/reports/challenges/submitters.sql

@@ -26,7 +26,10 @@ submission_metrics AS (
         'FAILED_CHECKPOINT_REVIEW',
         'DELETED'
       ) THEN NULL
-      WHEN provisional_review.provisional_score IS NOT NULL THEN provisional_review.provisional_score
+      WHEN provisional_review.has_provisional_review THEN CASE
+        WHEN provisional_review.provisional_score >= 0 THEN provisional_review.provisional_score
+        ELSE NULL
+      END
       WHEN s."initialScore"::double precision >= 0 THEN s."initialScore"::double precision
       ELSE NULL
     END AS provisional_score,
@@ -63,11 +66,12 @@ submission_metrics AS (
     LIMIT 1
   ) AS final_review ON TRUE
   LEFT JOIN LATERAL (
-    SELECT rs."aggregateScore" AS provisional_score
+    SELECT
+      TRUE AS has_provisional_review,
+      rs."aggregateScore" AS provisional_score
     FROM reviews."reviewSummation" AS rs
     WHERE rs."submissionId" = s.id
       AND rs."isProvisional" IS TRUE
-      AND rs."aggregateScore" >= 0
     ORDER BY COALESCE(rs."reviewedDate", rs."createdAt") DESC NULLS LAST, rs.id DESC
     LIMIT 1
   ) AS provisional_review ON TRUE

sql/reports/challenges/valid-submitters.sql

@@ -26,7 +26,10 @@ submission_metrics AS (
         'FAILED_CHECKPOINT_REVIEW',
         'DELETED'
       ) THEN NULL
-      WHEN provisional_review.provisional_score IS NOT NULL THEN provisional_review.provisional_score
+      WHEN provisional_review.has_provisional_review THEN CASE
+        WHEN provisional_review.provisional_score >= 0 THEN provisional_review.provisional_score
+        ELSE NULL
+      END
       WHEN s."initialScore"::double precision >= 0 THEN s."initialScore"::double precision
       ELSE NULL
     END AS provisional_score,
@@ -67,11 +70,12 @@ submission_metrics AS (
     LIMIT 1
   ) AS final_review ON TRUE
   LEFT JOIN LATERAL (
-    SELECT rs."aggregateScore" AS provisional_score
+    SELECT
+      TRUE AS has_provisional_review,
+      rs."aggregateScore" AS provisional_score
     FROM reviews."reviewSummation" AS rs
     WHERE rs."submissionId" = s.id
       AND rs."isProvisional" IS TRUE
-      AND rs."aggregateScore" >= 0
     ORDER BY COALESCE(rs."reviewedDate", rs."createdAt") DESC NULLS LAST, rs.id DESC
     LIMIT 1
   ) AS provisional_review ON TRUE

sql/reports/challenges/winners.sql

@@ -24,7 +24,10 @@ submission_metrics AS (
         'FAILED_CHECKPOINT_REVIEW',
         'DELETED'
       ) THEN NULL
-      WHEN provisional_review.provisional_score IS NOT NULL THEN provisional_review.provisional_score
+      WHEN provisional_review.has_provisional_review THEN CASE
+        WHEN provisional_review.provisional_score >= 0 THEN provisional_review.provisional_score
+        ELSE NULL
+      END
       WHEN s."initialScore"::double precision >= 0 THEN s."initialScore"::double precision
       ELSE NULL
     END AS provisional_score,
@@ -60,11 +63,14 @@ submission_metrics AS (
     LIMIT 1
   ) AS final_review ON TRUE
   LEFT JOIN LATERAL (
-    SELECT MAX(rs."aggregateScore") AS provisional_score
+    SELECT
+      TRUE AS has_provisional_review,
+      rs."aggregateScore" AS provisional_score
     FROM reviews."reviewSummation" AS rs
     WHERE rs."submissionId" = s.id
       AND rs."isProvisional" IS TRUE
-      AND rs."aggregateScore" >= 0
+    ORDER BY COALESCE(rs."reviewedDate", rs."createdAt") DESC NULLS LAST, rs.id DESC
+    LIMIT 1
   ) AS provisional_review ON TRUE
 ),
 winner_members AS MATERIALIZED (

src/reports/challenges/challenge-export-sql.spec.ts

@@ -34,22 +34,26 @@ describe("Challenge export SQL", () => {
       const sql = sqlLoader.load(sqlPath);
 
       expect(sql).toContain(
-        "WHEN provisional_review.provisional_score IS NOT NULL THEN provisional_review.provisional_score",
+        "WHEN provisional_review.has_provisional_review THEN CASE",
+      );
+      expect(sql).toContain(
+        "WHEN provisional_review.provisional_score >= 0 THEN provisional_review.provisional_score",
       );
       expect(sql).toContain(
         `WHEN s."initialScore"::double precision >= 0 THEN s."initialScore"::double precision`,
       );
+      expect(sql).toContain("TRUE AS has_provisional_review");
       expect(sql).toContain(`'FAILED_REVIEW'`);
       expect(sql).toContain(`'DELETED'`);
     },
   );
 
   it.each(challengeUserSqlPaths)(
-    "filters failed negative Marathon Match provisional scores in %s",
+    "guards failed Marathon Match provisional reviews before falling back in %s",
     (sqlPath) => {
       const sql = sqlLoader.load(sqlPath);
 
-      expect(sql).toContain(`AND rs."aggregateScore" >= 0`);
+      expect(sql).not.toContain(`AND rs."aggregateScore" >= 0`);
     },
   );