Skip to content

Commit 2671eff

Browse files
committed
contradiction at review context generation
1 parent dad6801 commit 2671eff

1 file changed

Lines changed: 36 additions & 5 deletions

File tree

  • workspace/skills/submission-guidelines-extraction

workspace/skills/submission-guidelines-extraction/SKILL.md

Lines changed: 36 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,33 @@ Where the final artifact lives:
9898

9999
### 7. `isPatchOfExisting`
100100

101-
Set to `true` when the challenge explicitly asks for a patch, diff, or
102-
incremental change to an existing codebase.
103-
104-
Set to `false` when the full codebase should be submitted or when it is
105-
a greenfield project.
101+
Set to `true` ONLY when ALL of the following are true:
102+
1. The challenge explicitly asks for a patch, diff, or incremental change
103+
2. An existing codebase is provided (repository URL, starter code, etc.)
104+
3. The existing_codebase.isGreenfield is `false`
105+
106+
Set to `false` when:
107+
- The full codebase should be submitted
108+
- It is a greenfield project (no existing code to patch)
109+
- No concrete repository URL or code artifacts are referenced
110+
111+
**CRITICAL CONSISTENCY CHECK:**
112+
`isPatchOfExisting` can ONLY be `true` when there is actual code to patch.
113+
If `existing_codebase.isGreenfield` is `true` (no existing codebase), then
114+
`isPatchOfExisting` MUST be `false` — you cannot create a patch against
115+
code that doesn't exist.
116+
117+
| existing_codebase.isGreenfield | isPatchOfExisting | Valid? |
118+
|-------------------------------|-------------------|--------|
119+
| `true` | `false` | YES |
120+
| `true` | `true` | NO - contradiction! |
121+
| `false` | `false` | YES (full code submission) |
122+
| `false` | `true` | YES (patch of existing) |
123+
124+
**Common mistake:** Challenge mentions "enhance", "update", or "extend"
125+
existing functionality but does NOT provide an actual repository URL or
126+
starter code. This is still a greenfield project — the submitter must
127+
build everything from scratch. Do NOT set `isPatchOfExisting: true`.
106128

107129
### 8. `eligibilityConditions`
108130

@@ -139,3 +161,12 @@ Any remaining submission information that doesn't fit the fields above.
139161
| "Include a README.md" | "README.md", "Documentation" | Redundant — README is the documentation |
140162
| "Your code should include tests" (in evaluation section) | "Test cases" | Evaluation guidance, not an explicit submission requirement |
141163
| "Security will be reviewed" | "Security report" | Review criteria, not a deliverable |
164+
165+
## isPatchOfExisting Mistakes to Avoid
166+
167+
| Spec says… | Wrong isPatchOfExisting | Why it's wrong |
168+
| ---------------------------------------------------------- | ---------------------- | ------------------------------------------------------------- |
169+
| "Enhance the existing processor" (no repo URL provided) | `true` | No actual repo/code to patch — this is greenfield |
170+
| "Update the Lambda to handle X" (describes current system) | `true` | Description of current state ≠ existing codebase to patch |
171+
| "We did a POC challenge previously" | `true` | Past work ≠ code artifact provided for this challenge |
172+
| isGreenfield=true in existing_codebase | `true` | **CONTRADICTION** — cannot patch non-existent code |

0 commit comments

Comments
 (0)