Fix position chart repair trade markers

Exclude repair counter-trades from position chart markers and use reserve notional as the marker USD value fallback for vault-style trades.

Author: miohtama

src/lib/trade-executor/helpers/position-chart.test.ts

@@ -151,6 +151,15 @@ describe('buildPositionChartsModel', () => {
 					planned_quantity: '0',
 					executed_quantity: '0',
 					flags: []
+				}),
+				createTrade({
+					trade_id: 4,
+					trade_type: 'repair',
+					planned_quantity: '5',
+					executed_quantity: '0',
+					planned_reserve: '5',
+					executed_reserve: '0',
+					repaired_trade_id: 2
 				})
 			]
 		});
@@ -161,6 +170,24 @@ describe('buildPositionChartsModel', () => {
 		expect(model.underlyingPrice.markers[0].tradeId).toBe(1);
 	});
 
+	test('uses planned reserve amount for vault marker USD value when executed quantity is zero', () => {
+		const payload = createPayload({
+			trades: [
+				createTrade({
+					planned_quantity: '123.45',
+					executed_quantity: '0',
+					planned_reserve: '123.45',
+					executed_reserve: '0'
+				})
+			]
+		});
+
+		const model = buildPositionChartsModel(payload);
+
+		expect(model.underlyingPrice.markers).toHaveLength(1);
+		expect(model.underlyingPrice.markers[0].tradeValueUsd).toBe(123.45);
+	});
+
 	test('falls back to underlying_price samples when price_history is missing', () => {
 		const payload = createPayload({
 			price_history: [],

src/lib/trade-executor/helpers/position-chart.ts

@@ -96,6 +96,7 @@ function normalisePoints(points: PositionChartPoint[]) {
 function getMarkerTrades(trades: TradeInfo[], tradePathBase: string) {
 	return trades
 		.filter((trade) => !trade.repaired_at)
+		.filter((trade) => !trade.isRepair)
 		.filter((trade) => {
 			const plannedQuantity = trade.planned_quantity;
 			const executedQuantity = trade.executed_quantity ?? 0;
@@ -114,7 +115,7 @@ function getMarkerTrades(trades: TradeInfo[], tradePathBase: string) {
 					directionLabel: trade.direction === TradeDirections.Enter ? 'Increase' : 'Decrease',
 					quantity: trade.executed_quantity ?? trade.planned_quantity ?? null,
 					price: trade.executed_price ?? null,
-					tradeValueUsd: trade.value,
+					tradeValueUsd: getTradeValueUsd(trade),
 					tradeUrl: `${tradePathBase}/trade-${trade.trade_id}`
 				}
 			];
@@ -163,3 +164,8 @@ function getNearestPoint(points: PositionChartPoint[], timestamp: number) {
 function getTradeTimestamp(trade: TradeInfo) {
 	return trade.executed_at ?? trade.failed_at ?? trade.started_at ?? trade.opened_at ?? null;
 }
+
+function getTradeValueUsd(trade: TradeInfo) {
+	const reserveValue = Math.abs(trade.executed_reserve || trade.planned_reserve || 0);
+	return reserveValue || trade.value;
+}