Register arg_iter as a supplementary lint

Author: smoelius

dylint-link/src/main.rs

@@ -102,10 +102,11 @@ where
 
 #[cfg(not(target_os = "windows"))]
 #[allow(clippy::unnecessary_wraps)]
-fn output_path<'a, I>(mut iter: I) -> Result<Option<PathBuf>>
+fn output_path<'a, I>(iter: I) -> Result<Option<PathBuf>>
 where
-    I: Iterator<Item = &'a String>,
+    I: IntoIterator<Item = &'a String>,
 {
+    let mut iter = iter.into_iter();
     while let Some(arg) = iter.next() {
         if arg == "-o" {
             if let Some(path) = iter.next() {

examples/general/non_local_effect_before_error_return/src/lib.rs

@@ -302,7 +302,7 @@ fn collect_locals_and_constants<'tcx>(
     cx: &LateContext<'tcx>,
     mir: &'tcx Body<'tcx>,
     path: &[BasicBlock],
-    args: impl Iterator<Item = &'tcx Operand<'tcx>>,
+    args: impl IntoIterator<Item = &'tcx Operand<'tcx>>,
 ) -> (DenseBitSet<Local>, Vec<&'tcx ConstOperand<'tcx>>) {
     let mut locals_narrowly = DenseBitSet::new_empty(mir.local_decls.len());
     let mut locals_widely = DenseBitSet::new_empty(mir.local_decls.len());

examples/supplementary/Cargo.lock

@@ -10,6 +10,7 @@ publish = false
 crate-type = ["cdylib"]
 
 [dependencies]
+arg_iter = { path = "arg_iter", features = ["rlib"] }
 commented_out_code = { path = "commented_out_code", features = ["rlib"] }
 escaping_doc_link = { path = "escaping_doc_link", features = ["rlib"] }
 inconsistent_struct_pattern = { path = "inconsistent_struct_pattern", features = [

examples/supplementary/Cargo.toml

@@ -10,6 +10,7 @@ extern crate rustc_session;
 #[unsafe(no_mangle)]
 pub fn register_lints(sess: &rustc_session::Session, lint_store: &mut rustc_lint::LintStore) {
     // smoelius: Please keep the following `register_lints` calls sorted by crate name.
+    arg_iter::register_lints(sess, lint_store);
     commented_out_code::register_lints(sess, lint_store);
     escaping_doc_link::register_lints(sess, lint_store);
     inconsistent_struct_pattern::register_lints(sess, lint_store);