fix(thrift): preserve dotted namespace in module IDs

Thrift namespace parts were joined with an empty string, mangling
`example.auth` into `exampleauth` in node IDs and breaking cross-file
referencing by package. Join with `.` to match the Proto parser's
behavior. Regenerate the thrift KAT snapshot and update the entrypoint
test expectation accordingly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: tob-scott-a

src/trailmark/parsers/thrift/parser.py

@@ -72,7 +72,7 @@ def _namespace_id(root: Node) -> str:
                 for part in named_children(child)
                 if part.type == "namespace"
             ]
-            return "".join(parts)
+            return ".".join(parts)
     return ""
 
 

tests/fixtures/kat/thrift/taxonomy.expected.json

@@ -3,51 +3,51 @@
     {
       "confidence": "certain",
       "kind": "imports",
-      "source": "exampleauth",
+      "source": "example.auth",
       "target": "common.thrift"
     },
     {
       "confidence": "certain",
       "kind": "contains",
-      "source": "exampleauth",
-      "target": "exampleauth:LoginRequest"
+      "source": "example.auth",
+      "target": "example.auth:LoginRequest"
     },
     {
       "confidence": "certain",
       "kind": "contains",
-      "source": "exampleauth:LoginRequest",
-      "target": "exampleauth:LoginRequest.token"
+      "source": "example.auth:LoginRequest",
+      "target": "example.auth:LoginRequest.token"
     },
     {
       "confidence": "certain",
       "kind": "contains",
-      "source": "exampleauth",
-      "target": "exampleauth:AuthService"
+      "source": "example.auth",
+      "target": "example.auth:AuthService"
     },
     {
       "confidence": "certain",
       "kind": "contains",
-      "source": "exampleauth:AuthService",
-      "target": "exampleauth:AuthService.login"
+      "source": "example.auth:AuthService",
+      "target": "example.auth:AuthService.login"
     },
     {
       "attributes": {
         "type_name": "LoginRequest"
       },
       "confidence": "certain",
       "kind": "type_uses",
-      "source": "exampleauth:AuthService.login",
-      "target": "exampleauth:LoginRequest"
+      "source": "example.auth:AuthService.login",
+      "target": "example.auth:LoginRequest"
     }
   ],
   "language": "thrift",
   "nodes": {
-    "exampleauth": {
+    "example.auth": {
       "branches": [],
       "cyclomatic_complexity": null,
       "docstring": null,
       "exception_types": [],
-      "id": "exampleauth",
+      "id": "example.auth",
       "kind": "module",
       "location": {
         "end_col": 0,
@@ -56,16 +56,16 @@
         "start_col": 0,
         "start_line": 1
       },
-      "name": "exampleauth",
+      "name": "example.auth",
       "parameters": [],
       "return_type": null
     },
-    "exampleauth:AuthService": {
+    "example.auth:AuthService": {
       "branches": [],
       "cyclomatic_complexity": null,
       "docstring": null,
       "exception_types": [],
-      "id": "exampleauth:AuthService",
+      "id": "example.auth:AuthService",
       "kind": "interface",
       "location": {
         "end_col": 1,
@@ -78,15 +78,15 @@
       "parameters": [],
       "return_type": null
     },
-    "exampleauth:AuthService.login": {
+    "example.auth:AuthService.login": {
       "attributes": {
         "schema_role": "service_function"
       },
       "branches": [],
       "cyclomatic_complexity": null,
       "docstring": null,
       "exception_types": [],
-      "id": "exampleauth:AuthService.login",
+      "id": "example.auth:AuthService.login",
       "kind": "method",
       "location": {
         "end_col": 33,
@@ -113,12 +113,12 @@
         "name": "bool"
       }
     },
-    "exampleauth:LoginRequest": {
+    "example.auth:LoginRequest": {
       "branches": [],
       "cyclomatic_complexity": null,
       "docstring": null,
       "exception_types": [],
-      "id": "exampleauth:LoginRequest",
+      "id": "example.auth:LoginRequest",
       "kind": "struct",
       "location": {
         "end_col": 1,
@@ -131,15 +131,15 @@
       "parameters": [],
       "return_type": null
     },
-    "exampleauth:LoginRequest.token": {
+    "example.auth:LoginRequest.token": {
       "attributes": {
         "schema_role": "field"
       },
       "branches": [],
       "cyclomatic_complexity": null,
       "docstring": null,
       "exception_types": [],
-      "id": "exampleauth:LoginRequest.token",
+      "id": "example.auth:LoginRequest.token",
       "kind": "method",
       "location": {
         "end_col": 17,

tests/test_entrypoints.py

@@ -143,7 +143,7 @@ def test_schema_entrypoints_detect_operations_only(self, tmp_path: Path) -> None
             "example.auth:Auth.Login",
         }
         assert {ep["node_id"] for ep in thrift.attack_surface()} == {
-            "exampleauth:Auth.login",
+            "example.auth:Auth.login",
         }
         assert {ep["node_id"] for ep in graphql.attack_surface()} == {
             "schema:Query.user",