routes.reverse() has adverse side effects

[scott-wyatt]

https://github.com/trailsjs/trailpack-express/blob/master/lib/server.js#L214

If I specify a route with * as my 404 this reverse does not make it the last route which is part of express spec. We might need to add a little bit smarter of route prioritization.

[jaumard]

I'm totally agree with you :( I didn't like this line at all ! But I didn't find something better for now :(
Any suggestions are welcome

[tjwebb]

One problem is that .reverse() reverses the array in place: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reverse. app.routes is being modified, which we don't want to do.

@jaumard why does express need to reverse the routes?

[scott-wyatt]

In my v3 pr, I re sort routes from trailpack-routes into a more correct Express validation

[scott-wyatt]

Trailpacks can create routes and express uses a top down validation for routes so they have to be sorted otherwise they won’t work as expected.