Move GitHub fetch from controllers to rake task

- Remove StarEvent.fetch_and_upsert calls from controllers
  (activities, dashboard, stars) - controllers now read from DB only
- Remove User#fetch_star_events (no longer needed)
- Add lib/tasks/fetch_star_events.rake for periodic background fetch
- Remove fetch_and_upsert stub from rails_helper (no longer needed)
- Skip Settings.url_options in test env to avoid BASE_URL port
  leaking into action_mailer.default_url_options

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: tricknotes

app/controllers/activities_controller.rb

@@ -4,7 +4,6 @@ class ActivitiesController < ApplicationController
 
   def starring
     @user = current_user
-    @user.fetch_star_events(since: 1.day.ago)
     @star_events = @user.star_events_by_followings_with_me.latest(1.day.ago)
   end
 

app/controllers/dashboard_controller.rb

@@ -2,7 +2,6 @@ class DashboardController < ApplicationController
   before_action :require_login, :assign_current_user
 
   def show
-    StarEvent.fetch_and_upsert(client: @user.github_client, logins: [@user.username], since: 7.days.ago)
     @star_events = StarEvent.by(@user.username).latest(7.days.ago).newly
     @starred_events = StarEvent.owner(@user.username).latest(7.days.ago).newly
   end

app/controllers/stars_controller.rb

@@ -5,7 +5,6 @@ class StarsController < ApplicationController
 
   def index
     @user = User.find_or_fetch_by_username(params[:username])
-    StarEvent.fetch_and_upsert(client: Settings.github_client, logins: [@user.username], since: 7.days.ago)
     @star_events = StarEvent.by(@user.username).latest(7.days.ago).newly
   end
 end

app/models/user.rb

@@ -61,11 +61,6 @@ def star_events_by_followings_with_me
     StarEvent.all_by(following_names + [username])
   end
 
-  def fetch_star_events(since:)
-    following_names = followings.map { |following| following['login'] }
-    StarEvent.fetch_and_upsert(client: github_client, logins: following_names + [username], since: since)
-  end
-
   def followings
     return @followings if @followings
 

config/application.rb

@@ -40,7 +40,9 @@ class Application < Rails::Application
     config.generators.system_tests = nil
 
     config.after_initialize do
-      Rails.application.default_url_options = Settings.url_options
+      unless Rails.env.test?
+        Rails.application.default_url_options = Settings.url_options
+      end
     end
   end
 end

lib/tasks/fetch_star_events.rake

@@ -0,0 +1,16 @@
+namespace :star_events do
+  desc 'Fetch star events for all users and their followings from GitHub'
+  task fetch: :environment do
+    since = 7.days.ago
+
+    User.find_each do |user|
+      following_names = user.followings.map { |following| following['login'] }
+      logins = (following_names + [user.username]).uniq
+
+      Rails.logger.info "Fetching star events for #{user.username} (and #{following_names.size} followings)"
+      StarEvent.fetch_and_upsert(client: user.github_client, logins: logins, since: since)
+    rescue => e
+      Rails.logger.error "Failed to fetch star events for #{user.username}: #{e.message}"
+    end
+  end
+end

spec/rails_helper.rb

@@ -21,7 +21,6 @@
   end
 
   config.before :each do
-    allow(StarEvent).to receive(:fetch_and_upsert)
     clear_mail_box
   end