Skip to content

Commit 061fbf5

Browse files
yinggehmc-nv
andauthored
Apply suggestions from code review
Co-authored-by: Misha Chornyi <99709299+mc-nv@users.noreply.github.com>
1 parent 85897d7 commit 061fbf5

2 files changed

Lines changed: 15 additions & 10 deletions

File tree

Dockerfile.sdk

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,9 @@ RUN if [ "$TRITON_ENABLE_GPU" = "ON" ]; then \
266266
https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2404/$arch/cuda-keyring_1.1-1_all.deb \
267267
&& apt install /tmp/cuda-keyring.deb && rm /tmp/cuda-keyring.deb && \
268268
apt update && \
269-
apt install --yes datacenter-gpu-manager-4-core=1:${DCGM_VERSION} && \
270-
apt install --yes datacenter-gpu-manager-4-dev=1:${DCGM_VERSION}; \
269+
apt install --yes --no-install-recommends \
270+
datacenter-gpu-manager-4-core=1:${DCGM_VERSION} \
271+
datacenter-gpu-manager-4-dev=1:${DCGM_VERSION}; \
271272
fi
272273

273274
# Build expects "python" executable (not python3).

build.py

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -858,8 +858,9 @@ def install_dcgm_libraries(dcgm_version, target_machine):
858858
# Install DCGM. Steps from https://developer.nvidia.com/dcgm#Downloads
859859
RUN dnf config-manager --add-repo https://developer.download.nvidia.com/compute/cuda/repos/rhel8/sbsa/cuda-rhel8.repo \\
860860
&& dnf clean expire-cache \\
861-
&& dnf install --assumeyes datacenter-gpu-manager-4-core=1:{} \\
862-
&& dnf install --assumeyes datacenter-gpu-manager-4-devel=1:{}
861+
&& dnf install --assumeyes \\
862+
datacenter-gpu-manager-4-core=1:{} \\
863+
datacenter-gpu-manager-4-devel=1:{}
863864
""".format(
864865
dcgm_version, dcgm_version, dcgm_version
865866
)
@@ -869,8 +870,9 @@ def install_dcgm_libraries(dcgm_version, target_machine):
869870
# Install DCGM. Steps from https://developer.nvidia.com/dcgm#Downloads
870871
RUN dnf config-manager --add-repo https://developer.download.nvidia.com/compute/cuda/repos/rhel8/x86_64/cuda-rhel8.repo \\
871872
&& dnf clean expire-cache \\
872-
&& dnf install --assumeyes datacenter-gpu-manager-4-core=1:{} \\
873-
&& dnf install --assumeyes datacenter-gpu-manager-4-devel=1:{}
873+
&& dnf install --assumeyes \\
874+
datacenter-gpu-manager-4-core=1:{} \\
875+
datacenter-gpu-manager-4-devel=1:{}
874876
""".format(
875877
dcgm_version, dcgm_version, dcgm_version
876878
)
@@ -884,8 +886,9 @@ def install_dcgm_libraries(dcgm_version, target_machine):
884886
&& apt install /tmp/cuda-keyring.deb \\
885887
&& rm /tmp/cuda-keyring.deb \\
886888
&& apt update \\
887-
&& apt install --yes datacenter-gpu-manager-4-core=1:{} \\
888-
&& apt install --yes datacenter-gpu-manager-4-dev=1:{}
889+
&& apt install --yes --no-install-recommends \\
890+
datacenter-gpu-manager-4-core=1:{} \\
891+
datacenter-gpu-manager-4-dev=1:{}
889892
""".format(
890893
dcgm_version, dcgm_version, dcgm_version
891894
)
@@ -898,8 +901,9 @@ def install_dcgm_libraries(dcgm_version, target_machine):
898901
&& apt install /tmp/cuda-keyring.deb \\
899902
&& rm /tmp/cuda-keyring.deb \\
900903
&& apt update \\
901-
&& apt install --yes datacenter-gpu-manager-4-core=1:{} \\
902-
&& apt install --yes datacenter-gpu-manager-4-dev=1:{}
904+
&& apt install --yes --no-install-recommends \\
905+
datacenter-gpu-manager-4-core=1:{} \\
906+
datacenter-gpu-manager-4-dev=1:{}
903907
""".format(
904908
dcgm_version, dcgm_version, dcgm_version
905909
)

0 commit comments

Comments
 (0)