Merge pull request #1234 from tsg-ut/test/startup-smoke-test-vitest

hakatashi · web-flow · commit 9a2b5b57c1fc · 2026-07-09T19:05:36.000+09:00
test: 起動時クラッシュを検知するスモークテストを追加
diff --git a/__mocks__/axios.js b/__mocks__/axios.js
@@ -1,6 +1,10 @@
 const {PassThrough} = require('stream');
 
-const axios = vi.fn((options = {}) => {
+const axios = vi.fn((urlOrConfig = {}, config = {}) => {
+	// axios.get(url, config) / axios.post(url, data, config) のように、第一引数が
+	// URL文字列で呼ばれるケースと、axios(config) のように設定オブジェクト単体で
+	// 呼ばれるケースの両方に対応する。
+	const options = typeof urlOrConfig === 'string' ? config : urlOrConfig;
 	if (options.responseType === 'stream') {
 		const stream = new PassThrough();
 		process.nextTick(() => {
@@ -13,9 +17,23 @@ const axios = vi.fn((options = {}) => {
 });
 axios.get = axios;
 axios.post = axios;
+axios.head = axios;
 
 axios.response = '';
 
+// axios.create() で作られたインスタンスは axios.defaults.* を直接
+// 読み書きできる必要がある(例: clientCH.defaults.withCredentials = false)。
+axios.defaults = {
+	headers: {
+		post: {},
+		common: {},
+	},
+};
+
+// axios.create() はconfigをbindした新しいaxiosインスタンスを返すのが実際の
+// 挙動だが、このモックでは単純に同じモックを返す。
+axios.create = () => axios;
+
 axios.default = {
 	defaults: {},
 };
diff --git a/__mocks__/sqlite.js b/__mocks__/sqlite.js
@@ -2,7 +2,10 @@ const sqlite = {};
 
 sqlite.open = vi.fn(() => ({
   all: vi.fn(() => Promise.resolve(sqlite.records)),
-  get: vi.fn(() => Promise.resolve(sqlite.records.length >= 1 ? sqlite.records[0] : null)),
+  // 実際の sqlite/sqlite3 driver は該当行が無い場合 undefined を返す(null ではない)。
+  get: vi.fn(() => Promise.resolve(sqlite.records.length >= 1 ? sqlite.records[0] : undefined)),
+  run: vi.fn(() => Promise.resolve()),
+  close: vi.fn(() => Promise.resolve()),
 }));
 
 sqlite.records = [];
diff --git a/atcoder/index.ts b/atcoder/index.ts
@@ -656,7 +656,6 @@ export default async ({eventClient, webClient: slack}: SlackInterface) => {
 			updateContests();
 		});
 	}, 30 * 60 * 1000);
-	updateContests();
 
 	let time = Date.now();
 	setInterval(() => {
diff --git a/emoxpand/index.ts b/emoxpand/index.ts
@@ -6,6 +6,7 @@ import logger from '../lib/logger';
 /* eslint-disable no-unused-vars */
 import type {SlackInterface, SlashCommandEndpoint} from '../lib/slack';
 import {getMemberName, getMemberIcon} from '../lib/slackUtils';
+import {Loader} from '../lib/utils';
 
 const log = logger.child({bot: 'emoxpand'});
 
@@ -39,20 +40,24 @@ const logError = (err: Error, mesg: string): void => {
 const emojiData = 'bigemojis.json';
 const emojiPath = path.resolve(__dirname, emojiData);
 
-let allEmojis : EmojiTable = new Map();
-
-const loadEmojis = async () => {
-  allEmojis = new Map();
-  const data = await fs.readFile(emojiPath, {encoding: 'utf8'});
-  const obj: {[key: string]: EmojiContent} = JSON.parse(data);
-  log.info('emoxpand: loading big emojis...');
-  for (const [name, content] of Object.entries(obj)) {
-    allEmojis.set(name, emojiFromContent(content));
+const emojisLoader = new Loader<EmojiTable>(async () => {
+  const emojis: EmojiTable = new Map();
+  try {
+    const data = await fs.readFile(emojiPath, {encoding: 'utf8'});
+    const obj: {[key: string]: EmojiContent} = JSON.parse(data);
+    log.info('emoxpand: loading big emojis...');
+    for (const [name, content] of Object.entries(obj)) {
+      emojis.set(name, emojiFromContent(content));
+    }
+  } catch (err: unknown) {
+    if (err instanceof Error && 'code' in err && err.code === 'ENOENT') {
+      logError(err, 'failed to load big emojis');
+    } else {
+      throw err;
+    }
   }
-  return allEmojis;
-};
-
-loadEmojis();
+  return emojis;
+});
 
 const emojisToJson = (emojis: EmojiTable): string => {
   const obj = Object.fromEntries(
@@ -66,7 +71,8 @@ const storeEmojis = (emojis: EmojiTable): void => {
 };
 
 
-const addEmoji = (name: EmojiName, emoji: BigEmoji): void => {
+const addEmoji = async (name: EmojiName, emoji: BigEmoji): Promise<void> => {
+  const allEmojis = await emojisLoader.load();
   allEmojis.set(name, emoji);
   storeEmojis(allEmojis);
 };
@@ -97,7 +103,8 @@ interface Token {
 }
 
 
-const expandEmoji = (text: string): string => {
+const expandEmoji = async (text: string): Promise<string> => {
+  const allEmojis = await emojisLoader.load();
   let replacementCount = 0;
   const result = _.flatMap(text.split('\n'), (line) => {
     const [, , tokens] = (line + '\n').split('').reduce<[TokenType, string[], Token[]]>(
@@ -112,7 +119,8 @@ const expandEmoji = (text: string): string => {
               kind: 'Plain',
               content: `!${content}!`,
             });
-          } else {
+          }
+          else {
             parsed.push({
               kind: parsing,
               content: chars.join(''),
@@ -208,7 +216,7 @@ export const server = ({eventClient, webClient: slack}: SlackInterface) => plugi
     }
     slack.chat.postMessage({
       channel: request.body.channel_id,
-      text: expandEmoji(request.body.text),
+      text: await expandEmoji(request.body.text),
       username: await getMemberName(request.body.user_id),
       icon_url: await getMemberIcon(request.body.user_id, 192),
     });
@@ -217,9 +225,10 @@ export const server = ({eventClient, webClient: slack}: SlackInterface) => plugi
   // }}}
 
   // Emoji list API {{{
-  fastify.get('/emoxpand/list', (_, response) => {
+  fastify.get('/emoxpand/list', async (_, response) => {
     response.header('Content-Type', 'applicaton/json').code(200);
-    return Promise.resolve(emojisToJson(allEmojis));
+    const allEmojis = await emojisLoader.load();
+    return emojisToJson(allEmojis);
   });
   // }}}
 
@@ -240,6 +249,7 @@ export const server = ({eventClient, webClient: slack}: SlackInterface) => plugi
 
     // Big Emoji list {{{
     if (/^大(?:絵文字|emoji)一覧$/.test(message.text)) {
+      const allEmojis = await emojisLoader.load();
       const emojiNames = Array.from(allEmojis.keys());
       if (emojiNames.length === 0) {
         postMessage('登録されている大絵文字はありません');
@@ -287,7 +297,7 @@ export const server = ({eventClient, webClient: slack}: SlackInterface) => plugi
             .split('\n')
             .map((row) =>
               row.slice(1, row.length - 1).split('::'));
-          addEmoji(state.name, emojiFromContent(contentLines));
+          await addEmoji(state.name, emojiFromContent(contentLines));
           postMessage(`大絵文字 \`!${state.name}!\`
 ${match.groups.content}
 が登録されました:sushi-go-left::waiwai::saikou::chian-ga-aru::sushi-go-right:`);
diff --git a/index.ts b/index.ts
@@ -24,6 +24,7 @@ import { inspect } from 'util';
 import concat from 'concat-stream';
 import { getAuthorityLabel } from './lib/slackUtils';
 import { closeDuplicateEventChecker } from './lib/eventDeduplication';
+import { productionBots, allBots } from './lib/bots';
 
 const log = logger.child({ bot: 'index' });
 
@@ -69,93 +70,6 @@ process.on('SIGUSR2', () => gracefulShutdown('SIGUSR2'));
 // pm2 reload
 process.on('SIGHUP', () => gracefulShutdown('SIGHUP'));
 
-const productionBots = [
-	'summary',
-	'mahjong',
-	'pocky',
-	'emoji-notifier',
-	'sushi-bot',
-	'shogi',
-	'tiobot',
-	'checkin',
-	'tahoiya',
-	'channel-notifier',
-	'prime',
-	'dajare',
-	'sunrise',
-	'ahokusa',
-	// ...(word2vecInstalled ? ['vocabwar'] : []),
-	'ricochet-robots',
-	'scrapbox',
-	'slack-log',
-	'welcome',
-	'deploy',
-	'achievements',
-	'mail-hook',
-	'wordhero',
-	'wordhero/crossword',
-	'oauth',
-	'tunnel',
-	'voiperrobot',
-	'atcoder',
-	'lyrics',
-	'better-custom-response',
-	'emoxpand',
-	'ponpe',
-	'anime',
-	'anime/anison',
-	'oogiri',
-	'sorting-riddles',
-	'tsglive',
-	'emoji-modifier',
-	'context-free',
-	'room-gacha',
-	'taiko',
-	'hayaoshi',
-	'twitter-dm-notifier',
-	'hitandblow',
-	'discord',
-	'octas',
-	'pwnyaa',
-	'amongyou',
-	'api',
-	'hangman',
-	'hakatashi-visor',
-	'nojoin',
-	'remember-english',
-	'golfbot',
-	'kirafan/quiz',
-	'topic',
-	'bungo-quiz',
-	'adventar',
-	'jantama',
-	'tabi-gatcha',
-	'achievement-quiz',
-	'wadokaichin',
-	'wordle-battle',
-	// 'slow-quiz',
-	'dicebot',
-	'taimai',
-	'map-guessr',
-	'character-quiz',
-	'shmug',
-	'pilot',
-	'qrcode-quiz',
-	'oneiromancy',
-	'auto-archiver',
-	'city-symbol',
-	'nmpz',
-	'autogen-quiz',
-	'twenty-questions',
-	'google-calendar',
-];
-
-const developmentBots = [
-	'helloworld',
-];
-
-const allBots = [...productionBots, ...developmentBots];
-
 log.info('slackbot started');
 
 const argv = yargs
diff --git a/lib/__mocks__/getReading.js b/lib/__mocks__/getReading.js
@@ -1,5 +1,3 @@
-const {vi} = require('vitest');
-
 const getReading = vi.fn((text) => (
 	Promise.resolve(getReading.virtualReadings.hasOwnProperty(text) ? getReading.virtualReadings[text] : '')
 ));
diff --git a/lib/__mocks__/state.ts b/lib/__mocks__/state.ts
@@ -51,3 +51,7 @@ const State: StateInterface = class State<StateObj> {
 export default State;
 
 export const ReadOnlyState = State;
+
+// lib/readOnlyState.ts は非production環境で StateDevelopment を
+// ReadOnlyState として使う。このモックにも同じ名前でexportしておく。
+export const StateDevelopment = State;
diff --git a/lib/bots.ts b/lib/bots.ts
@@ -0,0 +1,86 @@
+export const productionBots = [
+	'summary',
+	'mahjong',
+	'pocky',
+	'emoji-notifier',
+	'sushi-bot',
+	'shogi',
+	'tiobot',
+	'checkin',
+	'tahoiya',
+	'channel-notifier',
+	'prime',
+	'dajare',
+	'sunrise',
+	'ahokusa',
+	// ...(word2vecInstalled ? ['vocabwar'] : []),
+	'ricochet-robots',
+	'scrapbox',
+	'slack-log',
+	'welcome',
+	'deploy',
+	'achievements',
+	'mail-hook',
+	'wordhero',
+	'wordhero/crossword',
+	'oauth',
+	'tunnel',
+	'voiperrobot',
+	'atcoder',
+	'lyrics',
+	'better-custom-response',
+	'emoxpand',
+	'ponpe',
+	'anime',
+	'anime/anison',
+	'oogiri',
+	'sorting-riddles',
+	'tsglive',
+	'emoji-modifier',
+	'context-free',
+	'room-gacha',
+	'taiko',
+	'hayaoshi',
+	'twitter-dm-notifier',
+	'hitandblow',
+	'discord',
+	'octas',
+	'pwnyaa',
+	'amongyou',
+	'api',
+	'hangman',
+	'hakatashi-visor',
+	'nojoin',
+	'remember-english',
+	'golfbot',
+	'kirafan/quiz',
+	'topic',
+	'bungo-quiz',
+	'adventar',
+	'jantama',
+	'tabi-gatcha',
+	'achievement-quiz',
+	'wadokaichin',
+	'wordle-battle',
+	// 'slow-quiz',
+	'dicebot',
+	'taimai',
+	'map-guessr',
+	'character-quiz',
+	'shmug',
+	'pilot',
+	'qrcode-quiz',
+	'oneiromancy',
+	'auto-archiver',
+	'city-symbol',
+	'nmpz',
+	'autogen-quiz',
+	'twenty-questions',
+	'google-calendar',
+];
+
+export const developmentBots = [
+	'helloworld',
+];
+
+export const allBots = [...productionBots, ...developmentBots];
diff --git a/lib/slackMock.ts b/lib/slackMock.ts
@@ -169,6 +169,9 @@ export default class SlackMock extends EventEmitter implements SlackInterface {
 		if (stack.join('.') === "users.list") {
 			return Promise.resolve({ok: true, members: []});
 		}
+		if (stack.join('.') === "team.info") {
+			return Promise.resolve({ok: true, team: {id: this.fakeTeam, name: 'fakeTeam'}});
+		}
 		if (stack.join('.') === "conversations.list") {
 			return Promise.resolve({ok: true, channels: [
 				{id: 'CGENERAL', is_general: true},
diff --git a/lib/startup.test.ts b/lib/startup.test.ts
diff --git a/ponpe/index.ts b/ponpe/index.ts

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-const {vi} = require('vitest');`
`2`		`-`
`3`	`1`	`const getReading = vi.fn((text) => (`
`4`	`2`	`Promise.resolve(getReading.virtualReadings.hasOwnProperty(text) ? getReading.virtualReadings[text] : '')`
`5`	`3`	`));`