inject-app: Remove SLF4J-API logging bridges as dependencies

Problem

It is incorrect to blindly specify the SLF4J-API logging bridges
on the inject-app library of the framework at it causes trouble
for usages that cannot use Logback as an SLF4J-API logging
implementation.

Solution

Remove the SLF4J-API logging bridges as dependencies. Users
should provide the correct bridges as needed for their chosen
SLF4J-API logging implementation. Note that the `TwitterServer`
logging libraries will bring the correct bridges for the
given logging implementation so for users that include a
dependency on one of those libraries, there is nothing else that
needs to be done.

Result

Less conflicting logging implementations.

JIRA Issues: CSL-9669

Differential Revision: https://phabricator.twitter.biz/D854393

Author: cacoco

CHANGELOG.rst

@@ -10,6 +10,19 @@ Unreleased
 Runtime Behavior Changes
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
+* inject-app: Remove the SLF4J-API logging bridges as dependencies. These were originally
+  added as the framework was expressly opionated that users should use Logback as an SLF4J-API
+  implementation, however specifying the bridges on the Finatra inject/inject-app library
+  causes many issues with code that must use a different SLF4J-API logging implementation
+  but still uses the Finatra framework. Users should note that if they do not include these
+  bridges in some other manner that they may lose logging if they have any libraries which
+  log with one of the formerly bridged implementations. Also note that servers using a
+  `TwitterServer` logging implementation to support `dynamically changing log levels <https://twitter.github.io/twitter-server/Features.html#dynamically-change-log-levels>`__ will get the proper bridges as dependencies.
+  ``PHAB_ID=D854393``
+
+Runtime Behavior Changes
+~~~~~~~~~~~~~~~~~~~~~~~~
+
 * inject-server: Throw an `UnsupportedOperationException` when access to the `c.t.inject.server.DeprecatedLogging#log`
   instance is attempted. This is a JUL Logger instance which was provided only as a backward-compatible
   shim for Finatra services when the `c.t.server.TwitterServer` framework was moved to the `SLF4J-API`.

build.sbt

@@ -491,13 +491,6 @@ lazy val injectApp = (project in file("inject/inject-app"))
       "com.twitter" %% "util-core" % versions.twLibVersion,
       "com.twitter" %% "util-slf4j-jul-bridge" % versions.twLibVersion,
       "org.slf4j" % "slf4j-api" % versions.slf4j,
-      // -------- BEGIN: slf4j-api logging bridges -------------------------------
-      // Add the slf4j-api logging bridges to ensure that any dependents
-      // of the library have bridges on their classpath at runtime.
-      "org.slf4j" % "jcl-over-slf4j" % versions.slf4j,
-      "org.slf4j" % "jul-to-slf4j" % versions.slf4j,
-      "org.slf4j" % "log4j-over-slf4j" % versions.slf4j,
-      // -------- END: slf4j-api logging bridges ---------------------------------
       "org.slf4j" % "slf4j-simple" % versions.slf4j % "test-internal"
     ),
     ScoverageKeys.coverageExcludedPackages := "<empty>;.*TypeConverter.*",

inject/inject-app/src/main/scala/com/twitter/inject/app/BUILD

@@ -1,25 +1,3 @@
-# These are defined here and not on inject-slf4j to allow
-# for usage of the inject-slf4j library in environments
-# that don't want to bridge these impls. since the framework
-# recommendation is to use Logback for application logging
-# we add these here.
-target(
-    name = "logging-bridges",
-    tags = [
-        "bazel-compatible",
-        "logging_impl_check_whitelisted_target",
-    ],
-    dependencies = [
-        # -------- BEGIN: slf4j-api logging bridges -------------------------------
-        # Add the slf4j-api logging bridges to ensure that any dependents
-        # of the library have bridges on their classpath at runtime.
-        "3rdparty/jvm/org/slf4j:jcl-over-slf4j",
-        "3rdparty/jvm/org/slf4j:jul-to-slf4j",
-        "3rdparty/jvm/org/slf4j:log4j-over-slf4j",
-        # -------- END: slf4j-api logging bridges ---------------------------------
-    ],
-)
-
 scala_library(
     sources = ["*.scala"],
     compiler_option_sets = ["fatal_warnings"],
@@ -31,10 +9,6 @@ scala_library(
     strict_deps = True,
     tags = ["bazel-compatible"],
     dependencies = [
-        scoped(
-            ":logging-bridges",
-            scope = "runtime",
-        ),
         "3rdparty/jvm/com/google/inject:guice",
         "3rdparty/jvm/org/slf4j:slf4j-api",
         "finatra/inject/inject-app/src/main/java/com/twitter/inject/annotations",