Skip to content

Commit e7a2de2

Browse files
authored
rename CommonTagsInternal to InternalTags (#233)
* rename CommonTagsInternal to InternalTags
1 parent acc0d3c commit e7a2de2

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

m3/config.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ type Configuration struct {
5050
// with the histogram bucket bound values.
5151
HistogramBucketTagPrecision uint `yaml:"histogramBucketTagPrecision"`
5252

53-
// CommonTagsInternal are tags that should be added to all internal metrics
53+
// InternalTags are tags that should be added to all internal metrics
5454
// emitted by the reporter.
55-
CommonTagsInternal map[string]string `yaml:"commonTagsInternal"`
55+
InternalTags map[string]string `yaml:"internalTags"`
5656
}
5757

5858
// NewReporter creates a new M3 reporter from this configuration.
@@ -70,6 +70,6 @@ func (c Configuration) NewReporter() (Reporter, error) {
7070
MaxPacketSizeBytes: c.PacketSize,
7171
IncludeHost: c.IncludeHost,
7272
HistogramBucketTagPrecision: c.HistogramBucketTagPrecision,
73-
InternalTags: c.CommonTagsInternal,
73+
InternalTags: c.InternalTags,
7474
})
7575
}

m3/config_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ func TestConfigSimple(t *testing.T) {
4242
assert.True(t, ok)
4343
assert.True(t, tagEquals(reporter.commonTags, "service", "my-service"))
4444
assert.True(t, tagEquals(reporter.commonTags, "env", "test"))
45-
assert.Equal(t, 0, len(c.CommonTagsInternal))
45+
assert.Equal(t, 0, len(c.InternalTags))
4646
}
4747

4848
func TestConfigMulti(t *testing.T) {

0 commit comments

Comments
 (0)