solved test issues with k3d in test_field.py, test_mesh.py, test_region#543
Closed
AdamsMP92 wants to merge 2 commits into
Closed
solved test issues with k3d in test_field.py, test_mesh.py, test_region#543AdamsMP92 wants to merge 2 commits into
AdamsMP92 wants to merge 2 commits into
Conversation
Contributor
|
Failed to generate code suggestions for PR |
for more information, see https://pre-commit.ci
Member
|
The reason for the failure is a bug in k3d 2.17. #544 excludes that problematic version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fails in a non-IPython pytest session with
because
k3d.plot.plot_displaycallsdisplay(...)without importing it fromIPython.display.The purpose of these tests is to exercise the
discretisedfieldk3d plotting code paths, not to test whether the interactive Jupyter display machinery is available in a terminal pytest environment.Changes
k3d.plot()objects to k3d plotting calls in tests.plot.display()in tests.Field,Mesh, and subregion plotting.Test result
The local test suite now passes: