Skip to content

Commit 4662d2b

Browse files
authored
chore: remove localization messages from LazyPodcastPage instantiation (#1455)
1 parent 901cdf0 commit 4662d2b

5 files changed

Lines changed: 5 additions & 26 deletions

File tree

lib/app/view/create_master_items.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,7 @@ Iterable<MasterItem> createPodcastMasterItems(
142142
titleBuilder: (_) => PodcastPageTitle(feedUrl: feedUrl),
143143
subtitleBuilder: (_) => PodcastPageSubTitle(feedUrl: feedUrl),
144144
pageId: feedUrl,
145-
pageBuilder: (_) => LazyPodcastPage(
146-
feedUrl: feedUrl,
147-
updateMessage: context.l10n.newEpisodeAvailable,
148-
multiUpdateMessage: (length) =>
149-
context.l10n.newEpisodesAvailableFor(length),
150-
),
145+
pageBuilder: (_) => LazyPodcastPage(feedUrl: feedUrl),
151146
iconBuilder: (selected) => PodcastPageSideBarIcon(feedUrl: feedUrl),
152147
),
153148
);

lib/custom_content/view/custom_podcast_section.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,6 @@ class _CustomPodcastSectionState extends State<CustomPodcastSection> {
6868
di<RoutingManager>().push(
6969
pageId: _urlController.text,
7070
builder: (context) => LazyPodcastPage(
71-
updateMessage:
72-
context.l10n.newEpisodeAvailable,
73-
multiUpdateMessage: (length) => context
74-
.l10n
75-
.newEpisodesAvailableFor(length),
7671
imageUrl: v.firstOrNull?.imageUrl,
7772
feedUrl: _urlController.text,
7873
),

lib/player/view/player_title_and_artist.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -290,9 +290,6 @@ class PlayerTitleAndArtist extends StatelessWidget with WatchItMixin {
290290
builder: (_) => LazyPodcastPage(
291291
feedUrl: feedUrl,
292292
imageUrl: audio.imageUrl ?? audio.albumArtUrl,
293-
updateMessage: context.l10n.newEpisodeAvailable,
294-
multiUpdateMessage: (length) =>
295-
context.l10n.newEpisodesAvailableFor(length),
296293
),
297294
);
298295
}

lib/podcasts/view/lazy_podcast_page.dart

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,11 @@ class LazyPodcastPage extends StatefulWidget with WatchItStatefulWidgetMixin {
1919
this.podcastItem,
2020
this.feedUrl,
2121
this.imageUrl,
22-
required this.updateMessage,
23-
required this.multiUpdateMessage,
2422
});
2523

2624
final Item? podcastItem;
2725
final String? feedUrl;
2826
final String? imageUrl;
29-
final String updateMessage;
30-
final String Function(int length) multiUpdateMessage;
3127

3228
@override
3329
State<LazyPodcastPage> createState() => _LazyPodcastPageState();
@@ -56,8 +52,9 @@ class _LazyPodcastPageState extends State<LazyPodcastPage> {
5652
podcastModel.getPodcastEpisodesFromCache(url) == null) {
5753
await podcastModel.checkForUpdates(
5854
feedUrls: {url},
59-
updateMessage: widget.updateMessage,
60-
multiUpdateMessage: widget.multiUpdateMessage,
55+
updateMessage: context.l10n.newEpisodeAvailable,
56+
multiUpdateMessage: (length) =>
57+
context.l10n.newEpisodesAvailableFor(length),
6158
);
6259
}
6360

lib/search/view/podcast_card.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,7 @@ class PodcastCard extends StatelessWidget with WatchItMixin {
5656
onTap: feedUrl == null
5757
? null
5858
: () => di<RoutingManager>().push(
59-
builder: (_) => LazyPodcastPage(
60-
podcastItem: item,
61-
updateMessage: context.l10n.newEpisodeAvailable,
62-
multiUpdateMessage: (length) =>
63-
context.l10n.newEpisodesAvailableFor(length),
64-
),
59+
builder: (_) => LazyPodcastPage(podcastItem: item),
6560
pageId: feedUrl,
6661
),
6762
);

0 commit comments

Comments
 (0)