Divide by zero at line 695 in PosteriorBias/baseline_crf_prob.py

[ghzhang233]

reducingbias/PosteriorBias/baseline_crf_prob.py

Line 695 in ca3376e

verb_1, value_1, loss.item(), loss_total / ((total_steps) % (eval_frequency*len(train_loader) + 1)), (time.time() - time_all)))

It seems like that it should be
loss_total / ((total_steps - 1) % (eval_frequency*len(train_loader)) + 1)
rather than
loss_total / ((total_steps) % (eval_frequency*len(train_loader) + 1))
if I understand correctly.

[MtSomeThree]

Thanks for catching. It should be the second one, but neither of them will cause the divide-by-zero issue since the denominators are both >= 1. Could you check the eval_frequency or len(train_loader) value?

[ghzhang233]

Hi, @MtSomeThree ,
Thank you for replying!
For the code,
loss_total / ((total_steps) % (eval_frequency*len(train_loader) + 1))
please note that total_steps % (eval_frequency*len(train_loader) + 1) can be zero, as +1 is in the bracket.