From PR 268 in SRW:
It is convenient, and valuable in terms of its simplicity that we can hand an attrs: block to a function that simply creates XML attributes for the block's children, knowing that the input config passed validation; but IIRC cyclestr supports only certain predefined attributes, so we could also match keys against those, creating XML attributes for the ones we know represent those, and setting the XML element's text to the value: key's value. Combined with a previous comment, we might then be able to simplify
to
and
cyclestr:
attrs:
offset: offsetval
value: val
to
cyclestr:
offset: offsetval
value: val
We might also consider changing the value: tag to content: to match the XML spec.
From PR 268 in SRW:
It is convenient, and valuable in terms of its simplicity that we can hand an
attrs:block to a function that simply creates XML attributes for the block's children, knowing that the input config passed validation; but IIRCcyclestrsupports only certain predefined attributes, so we could also match keys against those, creating XML attributes for the ones we know represent those, and setting the XML element's text to thevalue:key's value. Combined with a previous comment, we might then be able to simplifyto
and
to
We might also consider changing the
value:tag tocontent:to match the XML spec.