Skip to content

Commit 0dba382

Browse files
authored
Merge pull request #230 from uhafner/fix-reference-guard
Fix broken guard condition in quality monitor action
2 parents c5e41d3 + 955be73 commit 0dba382

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

action.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,12 @@ runs:
5757
steps:
5858
- name: Download reference reports from main branch
5959
id: reference
60-
if: ${{ inputs.download-reference == 'true' }}
60+
if: ${{ inputs.enable-delta == 'true' }}
6161
uses: ./.github/actions/download-reference
62-
with:
63-
repository: ${{ inputs.repository }}
6462

6563
- name: Run Quality Monitor
66-
uses: docker://ghcr.io/uhafner/quality-monitor:4.14.1
64+
id: report
65+
uses: docker://ghcr.io/uhafner/quality-monitor:4.14.2
6766
env:
6867
CHECKS_NAME: ${{ inputs.checks-name }}
6968
COMMENTS_STRATEGY: ${{ inputs.comments-strategy }}

doc/dependency-graph.puml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ rectangle "commons-math3\n\n3.6.1" as org_apache_commons_commons_math3_jar
4848
rectangle "jackson-databind\n\n3.1.3" as tools_jackson_core_jackson_databind_jar
4949
rectangle "jackson-annotations\n\n2.21" as com_fasterxml_jackson_core_jackson_annotations_jar
5050
rectangle "jackson-core\n\n3.1.3" as tools_jackson_core_jackson_core_jar
51-
rectangle "quality-monitor\n\n4.14.1" as edu_hm_hafner_quality_monitor_jar
51+
rectangle "quality-monitor\n\n4.14.2" as edu_hm_hafner_quality_monitor_jar
5252
rectangle "jackson-databind\n\n2.21.4" as com_fasterxml_jackson_core_jackson_databind_jar
5353
rectangle "jackson-core\n\n2.21.4" as com_fasterxml_jackson_core_jackson_core_jar
5454
rectangle "github-api\n\n1.330" as org_kohsuke_github_api_jar
@@ -113,4 +113,4 @@ edu_hm_hafner_quality_monitor_jar -[#000000]-> com_google_errorprone_error_prone
113113
edu_hm_hafner_quality_monitor_jar -[#000000]-> org_apache_commons_commons_lang3_jar
114114
edu_hm_hafner_quality_monitor_jar -[#000000]-> commons_io_commons_io_jar
115115
edu_hm_hafner_quality_monitor_jar -[#000000]-> one_util_streamex_jar
116-
@enduml
116+
@enduml

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
<groupId>edu.hm.hafner</groupId>
1515
<artifactId>quality-monitor</artifactId>
16-
<version>4.14.1</version>
16+
<version>4.14.2</version>
1717
<packaging>jar</packaging>
1818

1919
<name>Quality Monitor GitHub Action</name>

src/test/java/edu/hm/hafner/grading/github/QualityMonitorDockerITest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ void shouldShowErrors() throws TimeoutException {
239239
}
240240

241241
private GenericContainer<?> createContainer() {
242-
return new GenericContainer<>(DockerImageName.parse("uhafner/quality-monitor:4.14.1"));
242+
return new GenericContainer<>(DockerImageName.parse("uhafner/quality-monitor:4.14.2"));
243243
}
244244

245245
private String readStandardOut(final GenericContainer<? extends GenericContainer<?>> container)

0 commit comments

Comments
 (0)