Skip to content

Commit c4c5bb7

Browse files
committed
refactor: remove coverage-badge target from Makefile
Align with cisco-wnc-exporter standards where coverage badge generation is done manually with octocov, not as a Makefile target. - Remove coverage-badge target from Makefile - Remove octocov requirement from help message - Update .PHONY declaration Coverage badge workflow (manual, matching cisco-wnc-exporter): 1. Run: make test-unit-coverage 2. Run: octocov badge coverage --out docs/assets/coverage.svg 3. Commit: coverage reports and badge together Secret check: pass Signed-off-by: umatare5 <umatare5@gmail.com> AI-assisted-by: GitHub Copilot Coding Agent
1 parent 893dc06 commit c4c5bb7

1 file changed

Lines changed: 1 addition & 9 deletions

File tree

Makefile

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.PHONY: help build lint test-unit test-unit-coverage coverage-badge clean
1+
.PHONY: help build lint test-unit test-unit-coverage clean
22

33
# Binary name and paths
44
BINARY_NAME := telee
@@ -20,12 +20,10 @@ help:
2020
@echo " lint - Run linters (golangci-lint)"
2121
@echo " test-unit - Run unit tests with colored output"
2222
@echo " test-unit-coverage - Generate HTML coverage report"
23-
@echo " coverage-badge - Generate coverage badge (SVG)"
2423
@echo " clean - Remove build artifacts and backup files"
2524
@echo ""
2625
@echo "Requirements:"
2726
@echo " - gotestsum: go install gotest.tools/gotestsum@latest"
28-
@echo " - octocov: go install github.com/k1LoW/octocov/cmd/octocov@latest"
2927
@echo " - golangci-lint: https://golangci-lint.run/usage/install/"
3028

3129
build: $(BINARY_PATH)
@@ -51,12 +49,6 @@ test-unit-coverage: test-unit
5149
go tool cover -html=$(COVERAGE_DIR)/report.out -o $(COVERAGE_DIR)/report.html
5250
@echo "Coverage report generated: $(COVERAGE_DIR)/report.html"
5351

54-
# Generate coverage badge (SVG)
55-
coverage-badge: test-unit
56-
@command -v octocov >/dev/null 2>&1 || { echo "Error: octocov is not installed. Run: go install github.com/k1LoW/octocov/cmd/octocov@latest"; exit 1; }
57-
octocov badge coverage --out docs/assets/coverage.svg
58-
@echo "Coverage badge generated: docs/assets/coverage.svg"
59-
6052
# Clean build artifacts and backup files
6153
clean:
6254
rm -rf $(BUILD_DIR) $(COVERAGE_DIR)

0 commit comments

Comments
 (0)