Skip to content

Commit 46b1e32

Browse files
committed
test: add type checks for hero ID to ensure it is a string
1 parent d6e9abe commit 46b1e32

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

tests/api/endpoints/test_heroes.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ def test_create_hero(client_with_db: TestClient, session: Session):
1515
assert data["name"] == "Deadpond"
1616
assert data["age"] is None
1717
assert data["id"] is not None
18+
assert isinstance(data["id"], str)
1819

1920

2021
def test_create_hero_incomplete(client: TestClient):
@@ -51,10 +52,12 @@ def test_read_heroes(session: Session, client_with_db: TestClient):
5152
assert data[0]["name"] == hero_1.name
5253
assert "secret_name" not in data[0].keys()
5354
assert data[0]["age"] == hero_1.age
55+
assert isinstance(data[0]["id"], str)
5456
assert data[0]["id"] == str(hero_1.id)
5557
assert data[1]["name"] == hero_2.name
5658
assert "secret_name" not in data[1].keys()
5759
assert data[1]["age"] == hero_2.age
60+
assert isinstance(data[1]["id"], str)
5861
assert data[1]["id"] == str(hero_2.id)
5962

6063

@@ -70,6 +73,7 @@ def test_read_hero(session: Session, client_with_db: TestClient):
7073
assert data["name"] == hero_1.name
7174
assert "secret_name" not in data.keys()
7275
assert data["age"] == hero_1.age
76+
assert isinstance(data["id"], str)
7377
assert data["id"] == str(hero_1.id)
7478

7579

@@ -85,6 +89,7 @@ def test_update_hero(session: Session, client_with_db: TestClient):
8589
assert data["name"] == "Deadpuddle"
8690
assert "secret_name" not in data.keys()
8791
assert data["age"] is None
92+
assert isinstance(data["id"], str)
8893
assert data["id"] == str(hero_1.id)
8994

9095

0 commit comments

Comments
 (0)