E2E: QA Added acceptance tests for AllowEditInvariantFromNonDefault setting in the nested block

[nhudinh0309]

This PR adds acceptance tests for the AllowEditInvariantFromNonDefault setting in the nested block

• AllowEditInvariantFromNonDefault = False

No	Outer Block List With Outer Element	Outer Element	Inner Block List with Inner Element	Inner Element	Text in Inner Element (under test)	Default Language (EN)	Non-Default Language (DA)
1	Varies By Culture	Varies By Culture	Varies By Culture	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
2	Varies By Culture	Varies By Culture	Varies By Culture	Varies By Culture	Shared	✓ Editable	✓ Editable
3	Varies By Culture	Varies By Culture	Varies By Culture	Shared	-	✓ Editable	✓ Editable
4	Varies By Culture	Varies By Culture	Shared	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
5	Varies By Culture	Varies By Culture	Shared	Varies By Culture	Shared	✓ Editable	✓ Editable
6	Varies By Culture	Varies By Culture	Shared	Shared	-	✓ Editable	✓ Editable
7	Varies By Culture	Shared	Shared	Varies By Culture	Varies By Culture	✓ Editable	✗ Readonly
8	Varies By Culture	Shared	Shared	Varies By Culture	Shared	✓ Editable	✗ Readonly
9	Varies By Culture	Shared	Shared	Shared	-	✓ Editable	✓ Editable
10	Shared	Varies By Culture	Varies By Culture	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
11	Shared	Varies By Culture	Varies By Culture	Varies By Culture	Shared	✓ Editable	✓ Editable
12	Shared	Varies By Culture	Varies By Culture	Shared	-	✓ Editable	✓ Editable
13	Shared	Varies By Culture	Shared	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
14	Shared	Varies By Culture	Shared	Varies By Culture	Shared	✓ Editable	✓ Editable
15	Shared	Varies By Culture	Shared	Shared	-	✓ Editable	✓ Editable
16	Shared	Shared	Shared	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
17	Shared	Shared	Shared	Varies By Culture	Shared	✓ Editable	✗ Readonly
18	Shared	Shared	Shared	Shared	-	✓ Editable	✗ Readonly

• AllowEditInvariantFromNonDefault = False

No	Outer Block List With Outer Element	Outer Element	Inner Block List with Inner Element	Inner Element	Text in Inner Element (under test)	Default Language (EN)	Non-Default Language (DA)
1	Varies By Culture	Varies By Culture	Varies By Culture	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
2	Varies By Culture	Varies By Culture	Varies By Culture	Varies By Culture	Shared	✓ Editable	✓ Editable
3	Varies By Culture	Varies By Culture	Varies By Culture	Shared	-	✓ Editable	✓ Editable
4	Varies By Culture	Varies By Culture	Shared	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
5	Varies By Culture	Varies By Culture	Shared	Varies By Culture	Shared	✓ Editable	✓ Editable
6	Varies By Culture	Varies By Culture	Shared	Shared	-	✓ Editable	✓ Editable
7	Varies By Culture	Shared	Shared	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
8	Varies By Culture	Shared	Shared	Varies By Culture	Shared	✓ Editable	✓ Editable
9	Varies By Culture	Shared	Shared	Shared	-	✓ Editable	✓ Editable
10	Shared	Varies By Culture	Varies By Culture	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
11	Shared	Varies By Culture	Varies By Culture	Varies By Culture	Shared	✓ Editable	✓ Editable
12	Shared	Varies By Culture	Varies By Culture	Shared	-	✓ Editable	✓ Editable
13	Shared	Varies By Culture	Shared	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
14	Shared	Varies By Culture	Shared	Varies By Culture	Shared	✓ Editable	✓ Editable
15	Shared	Varies By Culture	Shared	Shared	-	✓ Editable	✓ Editable
16	Shared	Shared	Shared	Varies By Culture	Varies By Culture	✓ Editable	✓ Editable
17	Shared	Shared	Shared	Varies By Culture	Shared	✓ Editable	✓ Editable
18	Shared	Shared	Shared	Shared	-	✓ Editable	✓ Editable

[claude]

Claude finished @nhudinh0309's task in 4m 10s —— View job

---

PR Review

Target: origin/main · Based on commit: e26a0aee
· Classified as: Test-only

Adds 36 Playwright E2E tests covering the AllowEditInvariantFromNonDefault setting across 18 nested-block variance combinations, for both the False (ContentSettingConfig) and True (DefaultConfig) configurations. Includes new helper methods for creating nested block list document types, creating multi-variant documents, and navigating/asserting block workspace properties.

---

Important

tests/Umbraco.Tests.AcceptanceTest/lib/helpers/ContentUiHelper.ts:1852 and :1857: Missing space between 'Add' and blockName in isAddBlockListElementWithNameDisabled and isAddBlockListElementWithNameVisible. The sibling method clickAddBlockListElementWithName at line 1847 correctly uses 'Add ' + blockName (note the trailing space), but the two methods below use 'Add' + blockName, producing e.g. "AddBlockList" instead of "Add BlockList". Both methods are actively called in existing tests (AllowEditInvariantFromNonDefaultIsFalse.spec.ts:155, AllowEditInvariantFromNonDefaultIsTrue.spec.ts:127,155), so this will cause those locators to silently not match.

// Line 1852 — fix:
const createNewButtonLocator = this.page.getByTestId(`property:${blockName.toLowerCase()}`).locator('uui-button').filter({hasText: 'Add ' + blockName});
// Line 1857 — fix:
const createNewButtonLocator = this.page.getByTestId(`property:${blockName.toLowerCase()}`).locator('uui-button').filter({hasText: 'Add ' + blockName});

Fix this →

---

tests/Umbraco.Tests.AcceptanceTest/package.json:26: The smokeTest script was repurposed to only execute the two new nested block spec files, removing all other tests previously covered by the @smoke suite. This looks like a development shortcut left in accidentally. Restore the original pattern (or tag the new tests @smoke and keep the generic grep).

// Restore to:
"smokeTest": "npm run build && npx playwright test DefaultConfig --grep \"@smoke\"",

Fix this →

---

Suggestions

• ...IsFalseNestedBlocks.spec.ts and ...IsTrueNestedBlocks.spec.ts: The two 145-line files are structurally identical — same imports, beforeEach/afterEach, formatCombo, and the full Act block. Only the daEditable values in matrixCases differ. Extracting shared scaffolding into a helper would halve the maintenance surface, though the flat style is consistent with neighbouring spec files.

• DocumentTypeApiHelper.ts:1226: require('crypto') is used inline, matching the existing pattern in the file. ES module import { randomUUID } from 'crypto' at the top would be cleaner if the file is ever migrated.

---

Request Changes

The missing space in the two ContentUiHelper locators will silently break existing passing tests, and the repurposed smokeTest script removes coverage from the smoke suite. Both should be addressed before merging.

[andr317c]

Had a few comments

[andr317c]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud