Discard Changes: Check before unload

[nielslyngsoe]

Checking for discard changes before unloading the page, aka. closing the tab/browser.

Cause the browser to ask if the user is sure about closing the tab when having unsaved changes

[claude]

Claude finished @nielslyngsoe's task in 2m 19s —— View job

---

PR Review

Target: origin/v17/dev · Based on commit: 36c2dcfe · Skipped: 0 noise files out of 1 total

Adds a beforeunload listener to UmbEntityDetailWorkspaceContextBase so the browser's native "Leave page?" confirmation appears when the user attempts to close a tab or browser window with unsaved changes.

• Affected implementations (outside this PR): All workspace contexts that extend UmbEntityDetailWorkspaceContextBase — directly: content-detail-workspace-base.ts, content-type-workspace-context-base.ts, entity-named-detail-workspace-base.ts. These all gain the new behavior automatically.

---

Suggestions

• entity-detail-workspace-base.ts:489–493: e.preventDefault() triggers the native dialog in Chrome 119+ (Oct 2023), Firefox 54+, and Safari 16.1+. Enterprise/backoffice environments sometimes run slightly behind; adding e.returnValue = '' as a fallback costs nothing and covers the gap:

  #onBeforeUnload = (e: BeforeUnloadEvent) => {
      if (this.getHasUnpersistedChanges()) {
          e.preventDefault();
          e.returnValue = ''; // legacy fallback for Chrome < 119 / Safari < 16.1
      }
  };

  This is a nice-to-have; e.preventDefault() alone is fine for any browser released in the last 2+ years.

---

Approved with Suggestions for improvement

Good to go, but please carefully consider the importance of the suggestions.

[Copilot]

Pull request overview

Adds an unload-time safeguard to entity detail workspaces so users are prompted before closing the tab/window when there are unpersisted changes.

Changes:

• Register a beforeunload handler to block page unload when getHasUnpersistedChanges() is true.
• Unregister the beforeunload handler in destroy() to avoid leaking listeners.

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!