Poorly typed return on @action decorator

[Verifitas]

What version of Unfold are you using?

Current master

Did you checked changelog/commit history, if the bug is not already fixed?

Yes.

Did you searched other issues, if the bug is not already fixed?

Yes.

Describe your issue

The @action decorator function has an incorrect type hint indicating that it returns Action object. It does not. It returns a wrapped function.

django-unfold/src/unfold/decorators.py

Line 27 in b1857a6

) -> Action:

[lukasvinclav]

What is a correct implementation?

[lukasvinclav]

@Verifitas hey, I'm just checking if you have had to check my question. I will be happy to review the PR :-)

[Kurl-Adam]

Hello, I just stumbled into this on an upgrade.

FWIW I think the correct implementation is something like:

def action(...)  -> Callable[[Callable], Action] | Action: ...

# assuming this is correct:
 def decorator(func: Callable) -> Action: ...

though it probably needs some overloads, and maybe additional tweaks, I'm not sure.
Decorator typing is hard :(

[Kurl-Adam]

Actually this might be ok - a bit lazy and doesn't check correctly inside the method, but seems to stop issues propagating out to implementation.

def action(...)  -> Callable: ...

def decorator(func: Callable) -> Callable: ...