Skip to content

Commit 7b7064f

Browse files
committed
docs(codex): record coderabbit fix loop
Purpose of the change: - Record the CodeRabbit fix-loop state for PR #62. - Keep the tracked WIP artifact aligned with the current review cleanup. How behavior was before: - The tracked WIP file described an older PR's CodeRabbit loop. - It did not reflect the current PR's resolved CodeRabbit item. Why that was a problem: - The repository's fix-loop audit artifact was stale for the active branch. What the new change accomplishes: - Documents the PR #62 CodeRabbit queue, evidence, and final checks. - Marks the inline CodeRabbit item and review-body summary as handled. How it works: - Updates .codex/coderabbit-fixes-wip.md with the current PR context, queue, validation evidence, and final re-check status.
1 parent 22fb72b commit 7b7064f

1 file changed

Lines changed: 11 additions & 34 deletions

File tree

.codex/coderabbit-fixes-wip.md

Lines changed: 11 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
## Context
44

55
- Repo: unraid/apprise-go
6-
- Branch: codex/telegram-formatting-followup
7-
- PR: #60
8-
- PR URL: https://github.com/unraid/apprise-go/pull/60
9-
- Generated at: 2026-05-21T00:36:00-04:00
6+
- Branch: codex/cli-help-parity
7+
- PR: #62
8+
- PR URL: https://github.com/unraid/apprise-go/pull/62
9+
- Generated at: 2026-05-21T14:29:52Z
1010

1111
## Inputs Pulled
1212

@@ -18,42 +18,19 @@
1818

1919
| Item ID | Type | File | Line | Summary | Status | Link | Evidence |
2020
| --- | --- | --- | --- | --- | --- | --- | --- |
21-
| CR-001 | thread | internal/notify/format_convert_test.go | 168 | Add Python parity to the cross-target corpus test. | BLOCKED | https://github.com/unraid/apprise-go/pull/60#discussion_r3278534673 | Skipped: this corpus intentionally validates target format conversion behavior that fixes Telegram behavior beyond current Python Apprise. Adding Python request parity would lock in the upstream bug this PR is fixing. |
22-
| CR-002 | thread | internal/notify/telegram_format_test.go | 140 | Route new Telegram format tests through Python-vs-Go request-sequence parity. | BLOCKED | https://github.com/unraid/apprise-go/pull/60#discussion_r3278534678 | Skipped: these tests assert corrected Telegram parse payloads that current Python Apprise does not emit. |
23-
| CR-003 | thread | internal/notify/live/telegram_live_test.go | 101 | Add Python-apprise request parity to the live Telegram test. | BLOCKED | https://github.com/unraid/apprise-go/pull/60#discussion_r3278534680 | Skipped: live test purpose is Bot API acceptance of corrected Go-generated Telegram parse payloads, not matching upstream Python's currently broken formatting. |
24-
| CR-004 | thread | internal/notify/live/telegram_live_test.go | n/a | Require explicit destination for the live suite. | DONE | https://github.com/unraid/apprise-go/pull/60#discussion_r3278534682 | Addressed in `a3dd48f`; GraphQL reports thread resolved/outdated. |
25-
| RVW-001 | review-body | internal/notify/live/telegram_live_test.go | 140-149 | Redact bot token from live test transport error logs. | DONE | https://github.com/unraid/apprise-go/pull/60#pullrequestreview-4320292462 | Added redaction helper and regression test; targeted and full Go tests passed. |
21+
| CR-001 | thread | internal/cli/cli.go | 212 | Unknown-option detection is over-applied and can misclassify non-unknown parse errors. | DONE | https://github.com/unraid/apprise-go/pull/62#discussion_r3281866028 | `go test ./internal/cli` passed; added regression for `-R not-an-int --blah`. |
22+
| RVW-001 | review-body | top-level | n/a | Review body reports one actionable comment, represented by CR-001. | DONE | https://github.com/unraid/apprise-go/pull/62#pullrequestreview-4337724219 | No separate top-level actionable item beyond CR-001. |
2623

2724
## Execution Log
2825

29-
### 1. Item: CR-004
30-
- Action: Required `APPRISE_GO_TELEGRAM_CHAT_ID` for live validation and removed auto-discovery/bot-ID fallback.
31-
- Validation: `go test ./internal/notify/live -run TestTelegramLiveFormattingAgainstBotAPI -count=1 -v` with explicit live env passed.
32-
- Result: DONE
33-
34-
### 2. Item: CR-001
35-
- Action: Verified this asks for parity against Python Apprise behavior that does not include the corrected Telegram conversions under test.
36-
- Validation: Code/test review.
37-
- Result: BLOCKED; skipped because it conflicts with the bug fix goal.
38-
39-
### 3. Item: CR-002
40-
- Action: Verified the requested parity would force the new Telegram unit tests back to current Python output.
41-
- Validation: Code/test review.
42-
- Result: BLOCKED; skipped because it conflicts with the bug fix goal.
43-
44-
### 4. Item: CR-003
45-
- Action: Verified live validation is intentionally testing Bot API acceptance of Go-generated corrected payloads.
46-
- Validation: Code/test review.
47-
- Result: BLOCKED; skipped because Python parity is not the purpose of this live suite.
48-
49-
### 5. Item: RVW-001
50-
- Action: Added token redaction before reporting request creation or transport errors.
51-
- Validation: `go test ./internal/notify/live -count=1`; `go test ./internal/notify ./internal/notify/live -run 'TestTelegram|TestTargetFormatConversionCorpusAcrossWorkflowTargets' -count=1`; live Bot API test with explicit env; `go test ./...`
26+
### 1. Item: CR-001
27+
- Action: Gated unknown-option formatting to only `flag provided but not defined` parse errors and left other parse failures on their real parser error path.
28+
- Validation: `go test ./internal/cli` passed.
5229
- Result: DONE
5330

5431
## Final Checks
5532

5633
- [x] Queue reviewed: no `TODO` left
5734
- [x] Remaining `BLOCKED` items documented with reason
58-
- [ ] Re-pulled CodeRabbit threads and reviews
59-
- [ ] No unhandled top-level review-body comment remains
35+
- [x] Re-pulled CodeRabbit threads and reviews
36+
- [x] No unhandled top-level review-body comment remains

0 commit comments

Comments
 (0)