cc tests: run ctest tests in parallel

* Added automatic assignment of cmake `RESOURCE_LOCK` properties to `userver_testsuite_add[_simple]`, `userver_add_utest` and `userver_add_ubench_test`. The locks are named `userver_<target>` for each major `userver::<target>`.
* Added a new `RESOURCE_LOCKS` parameter to `userver_testsuite_add[_simple]`. Use it to fix parallel ctest runs when using a database indirectly, e.g. through @ref scripts/docs/en/userver/odbc.md .
commit_hash:b4ccccf9fc4ee86af372146a111e6d1714427e29

Author: Anton3

.mapping.json

@@ -692,6 +692,7 @@
   "cmake/SetupScyllaDeps.cmake":"taxi/uservices/userver/cmake/SetupScyllaDeps.cmake",
   "cmake/SetupYdbCppSDK.cmake":"taxi/uservices/userver/cmake/SetupYdbCppSDK.cmake",
   "cmake/Stacktrace.cmake":"taxi/uservices/userver/cmake/Stacktrace.cmake",
+  "cmake/TargetIteration.cmake":"taxi/uservices/userver/cmake/TargetIteration.cmake",
   "cmake/UserverCodegenTarget.cmake":"taxi/uservices/userver/cmake/UserverCodegenTarget.cmake",
   "cmake/UserverCxxCompileOptionsIfSupported.cmake":"taxi/uservices/userver/cmake/UserverCxxCompileOptionsIfSupported.cmake",
   "cmake/UserverEmbedFile.cmake":"taxi/uservices/userver/cmake/UserverEmbedFile.cmake",

cmake/TargetIteration.cmake

@@ -0,0 +1,68 @@
+# Functions for traversing the CMake target link graph.
+#
+# Provides:
+#
+# * _userver_collect_linked_targets function that collects all targets a given target
+#   links against, directly or transitively.
+#
+# Implementation note: public functions here should be usable even without a direct
+# include of this script, so the functions should not rely on non-cache variables
+# being present.
+include_guard(GLOBAL)
+
+# Collects all CMake targets that `target` links against, directly or transitively,
+# into `output_var` (deduplicated). There is no built-in configure-time query for
+# transitive dependencies, so the link graph is walked iteratively over
+# LINK_LIBRARIES / INTERFACE_LINK_LIBRARIES. Link entries that are not plain targets
+# (raw libraries, generator expressions, etc.) are ignored without inspection.
+#
+# Membership is tracked via per-target marker variables (O(1) lookup) instead of a
+# list scan, so the traversal is linear in the number of targets and edges and is
+# immune to cycles and diamond-dependency blowup. The markers are plain function-local
+# variables: they are visible across the whole loop, are cleaned up automatically when
+# the function returns, and never leak between separate invocations.
+function(_userver_collect_linked_targets target output_var)
+    set(visited "")
+    set(frontier "${target}")
+
+    while(frontier)
+        set(next_frontier "")
+        foreach(current IN LISTS frontier)
+            if(NOT TARGET "${current}")
+                continue()
+            endif()
+
+            # Resolve aliases (e.g. userver::postgresql -> userver-postgresql).
+            get_target_property(aliased_target "${current}" ALIASED_TARGET)
+            if(aliased_target)
+                set(current "${aliased_target}")
+            endif()
+
+            string(MAKE_C_IDENTIFIER "userver_clt_seen_${current}" seen_marker)
+            if(DEFINED ${seen_marker})
+                continue()
+            endif()
+            set(${seen_marker} TRUE)
+            list(APPEND visited "${current}")
+
+            get_target_property(target_type "${current}" TYPE)
+            # LINK_LIBRARIES may not be read on INTERFACE libraries on old CMake.
+            if(NOT target_type STREQUAL "INTERFACE_LIBRARY")
+                get_target_property(link_libraries "${current}" LINK_LIBRARIES)
+                if(link_libraries)
+                    list(APPEND next_frontier ${link_libraries})
+                endif()
+            endif()
+            get_target_property(interface_libraries "${current}" INTERFACE_LINK_LIBRARIES)
+            if(interface_libraries)
+                list(APPEND next_frontier ${interface_libraries})
+            endif()
+        endforeach()
+        set(frontier "${next_frontier}")
+    endwhile()
+
+    set(${output_var}
+        "${visited}"
+        PARENT_SCOPE
+    )
+endfunction()

cmake/UserverTestsuite.cmake

@@ -15,6 +15,7 @@ include_guard(GLOBAL)
 # Pack initialization into a function to avoid non-cache variable leakage.
 function(_userver_prepare_testsuite)
     include("${CMAKE_CURRENT_LIST_DIR}/UserverVenv.cmake")
+    include("${CMAKE_CURRENT_LIST_DIR}/TargetIteration.cmake")
     set_property(GLOBAL PROPERTY userver_cmake_dir "${CMAKE_CURRENT_LIST_DIR}")
 
     # @ingroup libraries
@@ -143,7 +144,7 @@ endfunction()
 # TODO
 function(userver_testsuite_add)
     set(oneValueArgs SERVICE_TARGET TEST_SUFFIX WORKING_DIRECTORY PYTHON_BINARY PRETTY_LOGS SQL_LIBRARY)
-    set(multiValueArgs PYTEST_ARGS REQUIREMENTS PYTHONPATH TEST_ENV)
+    set(multiValueArgs PYTEST_ARGS REQUIREMENTS PYTHONPATH TEST_ENV RESOURCE_LOCKS)
     cmake_parse_arguments(ARG "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
 
     _userver_setup_environment_validate_impl()
@@ -207,7 +208,8 @@ function(userver_testsuite_add)
     set(TESTSUITE_RUNNER "${CMAKE_CURRENT_BINARY_DIR}/runtests-${service_target_with_suffix}")
     list(APPEND ARG_PYTHONPATH "${USERVER_TESTSUITE_DIR}/pytest_plugins")
 
-    file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/Testing/Temporary)
+    set(testsuite_temp_dir "${CMAKE_CURRENT_BINARY_DIR}/Testing/Temporary/${service_target_with_suffix}")
+    file(MAKE_DIRECTORY "${testsuite_temp_dir}")
 
     set(TESTS_PATHS ${ARG_WORKING_DIRECTORY})
     if(ARG_SQL_LIBRARY)
@@ -224,8 +226,8 @@ function(userver_testsuite_add)
             "${python_binary}" "${USERVER_TESTSUITE_DIR}/create_runner.py" "--output=${TESTSUITE_RUNNER}"
             "--python=${python_binary}" "--tests-path=${TESTS_PATHS}" "--working-dir=${CMAKE_CURRENT_BINARY_DIR}"
             "--python-path=${ARG_PYTHONPATH}" -- "--build-dir=${CMAKE_CURRENT_BINARY_DIR}"
-            "--service-logs-file=${CMAKE_CURRENT_BINARY_DIR}/Testing/Temporary/service.log"
-            "--basetemp=${CMAKE_CURRENT_BINARY_DIR}/Testing/Temporary" ${ARG_PYTEST_ARGS}
+            "--service-logs-file=${testsuite_temp_dir}/service.log"
+            "--basetemp=${testsuite_temp_dir}" ${ARG_PYTEST_ARGS}
         DEPENDS "${USERVER_TESTSUITE_DIR}/create_runner.py"
         COMMENT "Creating testsuite runner at ${TESTSUITE_RUNNER}"
         VERBATIM ${CODEGEN}
@@ -253,6 +255,13 @@ function(userver_testsuite_add)
         set_tests_properties("${testsuite_test_name}" PROPERTIES ENVIRONMENT "${ARG_TEST_ENV}")
     endif()
 
+    _userver_get_test_resource_locks_for_target("${ARG_SERVICE_TARGET}" testsuite_resource_locks)
+    list(APPEND testsuite_resource_locks ${ARG_RESOURCE_LOCKS})
+    if(testsuite_resource_locks)
+        list(REMOVE_DUPLICATES testsuite_resource_locks)
+        set_tests_properties("${testsuite_test_name}" PROPERTIES RESOURCE_LOCK "${testsuite_resource_locks}")
+    endif()
+
     # Pre-collect command in a list to support spaces in paths
     set(testsuite_start_command)
     list(APPEND testsuite_start_command "${python_binary}")
@@ -293,6 +302,8 @@ endfunction()
 # @multiparam REQUIREMENTS
 # @multiparam PYTHONPATH
 # @multiparam TEST_ENV
+# @multiparam RESOURCE_LOCKS ctest resource locks for databases the service uses
+#   without linking their module (e.g. 'userver_postgresql' for an odbc service)
 function(userver_testsuite_add_simple)
     set(oneValueArgs
         SERVICE_TARGET
@@ -307,7 +318,7 @@ function(userver_testsuite_add_simple)
         DUMP_CONFIG
         SQL_LIBRARY
     )
-    set(multiValueArgs PYTEST_ARGS REQUIREMENTS PYTHONPATH TEST_ENV)
+    set(multiValueArgs PYTEST_ARGS REQUIREMENTS PYTHONPATH TEST_ENV RESOURCE_LOCKS)
     cmake_parse_arguments(ARG "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
 
     _userver_setup_environment_validate_impl()
@@ -455,6 +466,7 @@ function(userver_testsuite_add_simple)
         REQUIREMENTS ${ARG_REQUIREMENTS}
         PYTHONPATH ${ARG_PYTHONPATH}
         TEST_ENV ${ARG_TEST_ENV}
+        RESOURCE_LOCKS ${ARG_RESOURCE_LOCKS}
         SQL_LIBRARY ${ARG_SQL_LIBRARY}
     )
 endfunction()
@@ -495,6 +507,14 @@ function(userver_add_utest)
     if(ARG_TEST_ENV)
         set_tests_properties("${ARG_NAME}" PROPERTIES ENVIRONMENT "${ARG_TEST_ENV}")
     endif()
+
+    set(utest_resource_locks "")
+    foreach(database IN LISTS ARG_DATABASES)
+        list(APPEND utest_resource_locks "userver_${database}")
+    endforeach()
+    if(utest_resource_locks)
+        set_tests_properties("${ARG_NAME}" PROPERTIES RESOURCE_LOCK "${utest_resource_locks}")
+    endif()
 endfunction()
 
 # @param NAME
@@ -528,4 +548,41 @@ function(userver_add_ubench_test)
     )
 endfunction()
 
+# Converts a target name into a ';'-separated list of ctest RESOURCE_LOCK names, one
+# per userver database module the target links against (directly or transitively).
+# Tests that share a lock are never run concurrently by ctest, which protects the
+# per-engine database daemons started by testsuite (each on a fixed port/data-dir)
+# from races during parallel `ctest -j`. Lock name for an engine is "userver_<engine>".
+function(_userver_get_test_resource_locks_for_target target output_var)
+    # userver database modules backed by a shared daemon. Embedded engines without a
+    # daemon (e.g. sqlite, rocks) are intentionally omitted.
+    set(db_engines
+        postgresql
+        mongo
+        redis
+        clickhouse
+        rabbitmq
+        kafka
+        mysql
+        ydb
+    )
+
+    set(resource_locks "")
+    if(TARGET "${target}")
+        _userver_collect_linked_targets("${target}" linked_targets)
+        foreach(engine IN LISTS db_engines)
+            list(FIND linked_targets "userver-${engine}" index_dash)
+            list(FIND linked_targets "userver::${engine}" index_colons)
+            if(NOT index_dash EQUAL -1 OR NOT index_colons EQUAL -1)
+                list(APPEND resource_locks "userver_${engine}")
+            endif()
+        endforeach()
+    endif()
+
+    set(${output_var}
+        "${resource_locks}"
+        PARENT_SCOPE
+    )
+endfunction()
+
 _userver_prepare_testsuite()

core/CMakeLists.txt

@@ -315,6 +315,7 @@ _userver_directory_install(
 _userver_directory_install(
     COMPONENT core
     FILES "${USERVER_ROOT_DIR}/cmake/UserverTestsuite.cmake"
+          "${USERVER_ROOT_DIR}/cmake/TargetIteration.cmake"
           "${USERVER_ROOT_DIR}/cmake/install/userver-core-config.cmake"
     DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/userver
 )

odbc/functional_tests/basic_chaos/CMakeLists.txt

@@ -5,4 +5,7 @@ target_link_libraries(${PROJECT_NAME} userver::odbc)
 
 userver_chaos_testsuite_add(
     ENV "TESTSUITE_PGSQL_SERVER_START_TIMEOUT=120.0"
+    # The odbc service talks to postgresql without linking userver::postgresql, so the
+    # shared lock must be declared explicitly.
+    RESOURCE_LOCKS userver_postgresql
 )

testsuite/SetupUserverTestsuiteEnv.cmake

@@ -13,7 +13,7 @@ userver_venv_setup(
 function(userver_chaos_testsuite_add)
     set(options)
     set(oneValueArgs TESTS_DIRECTORY)
-    set(multiValueArgs PYTHONPATH ENV)
+    set(multiValueArgs PYTHONPATH ENV RESOURCE_LOCKS)
     cmake_parse_arguments(ARG "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
 
     userver_testsuite_add_simple(
@@ -25,5 +25,7 @@ function(userver_chaos_testsuite_add)
         ${ARG_PYTHONPATH}
         TEST_ENV
         "${ARG_ENV}"
+        RESOURCE_LOCKS
+        ${ARG_RESOURCE_LOCKS}
     )
 endfunction()