fix: skip unchanged first-run domain status emails

Author: KMKoushik

apps/web/src/server/service/domain-service.ts

@@ -212,14 +212,20 @@ function shouldContinueVerifying(
 }
 
 function shouldSendDomainStatusNotification({
+  previousStatus,
   currentStatus,
   hasEverVerified,
   lastNotifiedStatus,
 }: {
+  previousStatus: DomainStatus;
   currentStatus: DomainStatus;
   hasEverVerified: boolean;
   lastNotifiedStatus: DomainStatus | null;
 }) {
+  if (lastNotifiedStatus === null && currentStatus === previousStatus) {
+    return false;
+  }
+
   if (hasEverVerified) {
     return currentStatus !== lastNotifiedStatus;
   }
@@ -524,6 +530,7 @@ export async function refreshDomainVerification(
 
   if (
     shouldSendDomainStatusNotification({
+      previousStatus,
       currentStatus: updatedDomain.status,
       hasEverVerified:
         verificationState.hasEverVerified ||

apps/web/src/server/service/domain-service.unit.test.ts

@@ -243,6 +243,39 @@ describe("domain-service", () => {
     expect(mockSendMail).not.toHaveBeenCalled();
   });
 
+  it("does not send status email on first refresh when status is unchanged", async () => {
+    const domain = createDomain({
+      status: DomainStatus.SUCCESS,
+      dkimStatus: DomainStatus.SUCCESS,
+      spfDetails: DomainStatus.SUCCESS,
+      isVerifying: false,
+    });
+    mockRedis.mget.mockResolvedValue([null, null, null]);
+    mockGetDomainIdentity.mockResolvedValue({
+      DkimAttributes: { Status: DomainStatus.SUCCESS },
+      MailFromAttributes: { MailFromDomainStatus: DomainStatus.SUCCESS },
+      VerificationInfo: {
+        ErrorType: null,
+        LastCheckedTimestamp: new Date("2026-03-09T12:00:00.000Z"),
+      },
+      VerificationStatus: DomainStatus.SUCCESS,
+    });
+    mockDb.domain.update.mockResolvedValue(
+      createDomain({
+        status: DomainStatus.SUCCESS,
+        dkimStatus: DomainStatus.SUCCESS,
+        spfDetails: DomainStatus.SUCCESS,
+        dmarcAdded: true,
+        isVerifying: false,
+      }),
+    );
+
+    await refreshDomainVerification(domain);
+
+    expect(mockSendMail).not.toHaveBeenCalled();
+    expect(wasLastNotifiedStatusStored()).toBe(false);
+  });
+
   it("reserves the notification so concurrent refreshes do not double-send", async () => {
     const domain = createDomain();
     mockRedis.mget.mockResolvedValue([null, null, null]);