Fix performance issues detected by RuboCop

After installing `rubocop-performance` and running it, it showed some
suggestions to improve the overall performance.

Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>

Author: nodeg

.rubocop.yml

@@ -1,6 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
 plugins:
+  - rubocop-performance
   - rubocop-rake
   - rubocop-rspec
 

Gemfile.lock

@@ -110,6 +110,10 @@ GEM
     rubocop-ast (1.49.0)
       parser (>= 3.3.7.2)
       prism (~> 1.7)
+    rubocop-performance (1.26.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
@@ -154,6 +158,7 @@ DEPENDENCIES
   rake (~> 13.3)
   rspec (~> 3.13)
   rubocop (~> 1.82.1)
+  rubocop-performance (~> 1.26)
   rubocop-rake (~> 0.7.1)
   rubocop-rspec (~> 3.9.0)
   simplecov (~> 0.22)
@@ -214,6 +219,7 @@ CHECKSUMS
   rspec-support (3.13.6) sha256=2e8de3702427eab064c9352fe74488cc12a1bfae887ad8b91cba480ec9f8afb2
   rubocop (1.82.1) sha256=09f1a6a654a960eda767aebea33e47603080f8e9c9a3f019bf9b94c9cab5e273
   rubocop-ast (1.49.0) sha256=49c3676d3123a0923d333e20c6c2dbaaae2d2287b475273fddee0c61da9f71fd
+  rubocop-performance (1.26.1) sha256=cd19b936ff196df85829d264b522fd4f98b6c89ad271fa52744a8c11b8f71834
   rubocop-rake (0.7.1) sha256=3797f2b6810c3e9df7376c26d5f44f3475eda59eb1adc38e6f62ecf027cbae4d
   rubocop-rspec (3.9.0) sha256=8fa70a3619408237d789aeecfb9beef40576acc855173e60939d63332fdb55e2
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33

lib/tetra/facades/git.rb

@@ -99,7 +99,7 @@ def undo_last_commit
     def disable_special_files(path)
       Dir.chdir(File.join(@directory, path)) do
         Find.find(".") do |file|
-          next unless file =~ /\.git(ignore)?$/
+          next unless /\.git(ignore)?$/.match?(file)
 
           FileUtils.mv(file, "#{file}_disabled_by_tetra")
         end

lib/tetra/maven_website.rb

@@ -49,7 +49,7 @@ def get_maven_id_from(result)
 
     # downloads a POM from a search.maven.com search result
     def download_pom(group_id, artifact_id, version)
-      path = "#{group_id.gsub('.', '/')}/#{artifact_id}/#{version}/#{artifact_id}-#{version}.pom"
+      path = "#{group_id.tr('.', '/')}/#{artifact_id}/#{version}/#{artifact_id}-#{version}.pom"
       log.debug("downloading #{path}...")
       get("https://repo1.maven.org/maven2/#{path}", {}).to_s
     end

lib/tetra/pom_getter.rb

@@ -21,7 +21,9 @@ def get_pom_from_jar(file)
       log.debug("Attempting unpack of #{file} to find a POM")
       begin
         Zip::File.foreach(file) do |entry|
-          if entry.name =~ %r{/pom.xml$}
+          next if entry.name.include?("..") || entry.name.start_with?("/")
+
+          if %r{/pom.xml$}.match?(entry.name)
             log.info("pom.xml found in #{file}##{entry.name}")
             return entry.get_input_stream.read, :found_in_jar
           end
@@ -41,8 +43,7 @@ def get_pom_from_sha1(file)
         if File.file?(file)
           site = MavenWebsite.new
           sha1 = Digest::SHA1.hexdigest File.read(file)
-          results = site.search_by_sha1(sha1).select { |result| result["ec"].include?(".pom") }
-          result = results.first
+          result = site.search_by_sha1(sha1).find { |result| result["ec"].include?(".pom") }
           unless result.nil?
             log.info("pom.xml for #{file} found on search.maven.org for sha1 #{sha1}\
               (#{result['g']}:#{result['a']}:#{result['v']})"
@@ -81,7 +82,7 @@ def get_pom_from_heuristic(filename)
               their_versions.max
             end
           )
-          best_matched_result = results.select { |r| r["v"] == best_matched_version }.first
+          best_matched_result = results.find { |r| r["v"] == best_matched_version }
 
           group_id, artifact_id, version = site.get_maven_id_from(best_matched_result)
           log.warn("pom.xml for #{filename} found on search.maven.org with heuristic search\

lib/tetra/project_initer.rb

@@ -75,7 +75,7 @@ def commit_source_archive(file, message)
         FileUtils.cp(file, result_path)
         @git.commit_file(result_path, "Source archive added")
 
-        unarchiver = if file =~ /\.zip$/
+        unarchiver = if /\.zip$/.match?(file)
                        Tetra::Unzip.new
                      else
                        Tetra::Tar.new

tetra.gemspec

@@ -32,6 +32,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rake", "~> 13.3"
   s.add_development_dependency "rspec", "~> 3.13"
   s.add_development_dependency "rubocop", "~> 1.82.1"
+  s.add_development_dependency "rubocop-performance", "~> 1.26"
   s.add_development_dependency "rubocop-rake", "~> 0.7.1"
   s.add_development_dependency "rubocop-rspec", "~> 3.9.0"