Apply suggestions form Copilot

Author: nodeg

lib/tetra/constants.rb

@@ -5,4 +5,12 @@ module Tetra
   CCOLLECTIONS = "commons-collections4-4.5.0-M2-src".freeze
   CHUNK_SEPARATOR_VERSION_MATCHER = /[.\-_ ~,]/ # Constant regex for splitting version chunks
   LICENSE_MAP_PATH = File.join(__dir__, "data", "license_map.yml").freeze
+  LICENSE_MAPPINGS = {
+    "The Apache Software License, Version 2.0" => "Apache-2.0",
+    "The MIT License" => "MIT",
+    "Eclipse Public License 1.0" => "EPL-1.0",
+    "GNU General Public License, version 2" => "GPL-2.0-only",
+    "GNU Lesser General Public License" => "LGPL-2.1-only",
+    "Unmapped Custom License" => "Unmapped Custom License"
+  }.freeze
 end

spec/lib/coarse/license_detection_spec.rb

@@ -21,19 +21,8 @@ def create_pom(group_id, artifact_id, version, license_name)
     XML
   end
 
-  let(:test_cases) do
-    {
-      "The Apache Software License, Version 2.0" => "Apache-2.0",
-      "The MIT License" => "MIT",
-      "Eclipse Public License 1.0" => "EPL-1.0",
-      "GNU General Public License, version 2" => "GPL-2.0-only",
-      "GNU Lesser General Public License" => "LGPL-2.1-only",
-      "Unmapped Custom License" => "Unmapped Custom License"
-    }
-  end
-
-  it "detects license names and converts them to SPDX" do
-    test_cases.each do |raw_name, expected_spdx|
+  Tetra::LICENSE_MAPPINGS.each do |raw_name, expected_spdx|
+    it "correctly maps '#{raw_name}' to '#{expected_spdx}'" do
       project_name = "proj-#{expected_spdx.downcase.gsub(/[^a-z0-9]/, "")}"
       version      = "1.0"
       group_id     = "com.example"
@@ -49,19 +38,19 @@ def create_pom(group_id, artifact_id, version, license_name)
       run_command_and_stop("tetra init #{project_name} #{tarball_name}")
 
       cd(project_name) do
+        # NOTE: Identity is already set in spec_helper's around hook,
+        # but we can keep these for explicit project-level config
         run_command_and_stop("git config user.email 'test@example.com'")
         run_command_and_stop("git config user.name 'Test User'")
 
         # --- NON-INTERACTIVE DRY-RUN ---
-        # We use a heredoc to pipe the commands directly.
         run_command("tetra dry-run")
         last_command_started.write <<~COMMANDS
           touch #{project_name}-#{version}.jar
           echo 'changes' >> README
           exit 0
         COMMANDS
 
-        # Stop will wait for the pipe to close and the process to exit naturally
         last_command_started.stop
         expect(last_command_started).to be_successfully_executed
 

spec/spec_helper.rb

@@ -37,6 +37,8 @@
 
     bin_path = File.expand_path(File.join(__dir__, "..", "bin"))
 
+    # Apply changes to global ENV (affects Ruby unit tests)
+    # Subprocesses spawned by Aruba inherit this modified PATH automatically
     ENV["PATH"] = "#{bin_path}#{File::PATH_SEPARATOR}#{original_env["PATH"]}"
     ENV["GIT_AUTHOR_NAME"] = "Tetra Test"
     ENV["GIT_AUTHOR_EMAIL"] = "test@example.com"
@@ -45,9 +47,7 @@
 
     # Apply changes to Aruba (affects subprocesses/coarse tests)
     if respond_to?(:set_environment_variable)
-      # NOTE: set_environment_variable overwrites
-      #       prepend_environment_variable appends
-      prepend_environment_variable("PATH", bin_path + File::PATH_SEPARATOR)
+      # NOTE: set_environment_variable overwrites.
       set_environment_variable("GIT_AUTHOR_NAME", "Tetra Test")
       set_environment_variable("GIT_AUTHOR_EMAIL", "test@example.com")
       set_environment_variable("GIT_COMMITTER_NAME", "Tetra Test")