Skip to content

Commit 4c20025

Browse files
authored
Merge pull request #820 from aaannz/healthy_notify
Revert "Notify systemd only once db and server containers are healthy" (bsc#1270399, bsc#1270398)
2 parents 329966d + 2d1fcfe commit 4c20025

5 files changed

Lines changed: 15 additions & 13 deletions

File tree

mgradm/shared/templates/pgsqlServiceTemplate.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ ExecStart=/bin/sh -c '/usr/bin/podman run \
3333
--cgroups=no-conmon \
3434
--shm-size=0 \
3535
--shm-size-systemd=0 \
36-
--sdnotify=healthy \
36+
--sdnotify=conmon \
37+
-d \
3738
--name {{ .NamePrefix }}-db \
3839
--hostname {{ .NamePrefix }}-db.mgr.internal \
3940
--network-alias db \
@@ -67,8 +68,7 @@ ExecStopPost=/usr/bin/podman rm \
6768
PIDFile=%t/%n.pid
6869
TimeoutStopSec=180
6970
TimeoutStartSec=900
70-
Type=notify
71-
NotifyAccess=all
71+
Type=forking
7272
7373
[Install]
7474
WantedBy=multi-user.target default.target

mgradm/shared/templates/serviceTemplate.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,9 @@ ExecStart=/bin/sh -c '/usr/bin/podman run \
3131
--cgroups=no-conmon \
3232
--shm-size=0 \
3333
--shm-size-systemd=0 \
34-
--sdnotify=healthy \
34+
--sdnotify=conmon \
3535
--systemd=always \
36+
-d \
3637
--name {{ .NamePrefix }}-server \
3738
--hostname {{ .NamePrefix }}-server.mgr.internal \
3839
{{ .Args }} \
@@ -86,8 +87,7 @@ ExecStopPost=/usr/bin/podman rm \
8687
PIDFile=%t/uyuni-server.pid
8788
TimeoutStopSec=180
8889
TimeoutStartSec=900
89-
Type=notify
90-
NotifyAccess=all
90+
Type=forking
9191
9292
[Install]
9393
WantedBy=multi-user.target default.target

mgradm/shared/templates/templates_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,9 @@ ExecStart=/bin/sh -c '/usr/bin/podman run \
115115
--cgroups=no-conmon \
116116
--shm-size=0 \
117117
--shm-size-systemd=0 \
118-
--sdnotify=healthy \
118+
--sdnotify=conmon \
119119
--systemd=always \
120+
-d \
120121
--name uyuni-server \
121122
--hostname uyuni-server.mgr.internal \
122123
--arg value \
@@ -158,8 +159,7 @@ ExecStopPost=/usr/bin/podman rm \
158159
PIDFile=%t/uyuni-server.pid
159160
TimeoutStopSec=180
160161
TimeoutStartSec=900
161-
Type=notify
162-
NotifyAccess=all
162+
Type=forking
163163
164164
[Install]
165165
WantedBy=multi-user.target default.target
@@ -203,8 +203,9 @@ ExecStart=/bin/sh -c '/usr/bin/podman run \
203203
--cgroups=no-conmon \
204204
--shm-size=0 \
205205
--shm-size-systemd=0 \
206-
--sdnotify=healthy \
206+
--sdnotify=conmon \
207207
--systemd=always \
208+
-d \
208209
--name uyuni-server \
209210
--hostname uyuni-server.mgr.internal \
210211
--arg value \
@@ -238,8 +239,7 @@ ExecStopPost=/usr/bin/podman rm \
238239
PIDFile=%t/uyuni-server.pid
239240
TimeoutStopSec=180
240241
TimeoutStartSec=900
241-
Type=notify
242-
NotifyAccess=all
242+
Type=forking
243243
244244
[Install]
245245
WantedBy=multi-user.target default.target
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- Revert usage of sdnotify as it causes podman panic on SP7
2+
(bsc#1270399, bsc#1270398)

uyuni-tools.spec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Requires: (netavark if podman)
116116
Requires: openssl
117117
# suse_version
118118
%if "%{_vendor}" != "debbuild"
119-
Requires: (podman >= 4.7.2 if podman)
119+
Requires: (podman >= 4.5.0 if podman)
120120
%endif
121121

122122
%description -n %{name_adm}

0 commit comments

Comments
 (0)