flags should be checked before podman login

Author: mbussolotto

mgradm/cmd/install/podman/utils.go

@@ -38,6 +38,11 @@ func installForPodman(
 	if err != nil {
 		return err
 	}
+	flags.ServerFlags.CheckParameters()
+	flags.Installation.CheckParameters(cmd, "podman")
+	if _, err := exec.LookPath("podman"); err != nil {
+		return errors.New(L("install podman before running this command"))
+	}
 
 	authFile, cleaner, err := shared_podman.PodmanLogin(hostData, flags.Installation.SCC, flags.Image)
 	if err != nil {
@@ -51,12 +56,6 @@ func installForPodman(
 		)
 	}
 
-	flags.ServerFlags.CheckParameters()
-	flags.Installation.CheckParameters(cmd, "podman")
-	if _, err := exec.LookPath("podman"); err != nil {
-		return errors.New(L("install podman before running this command"))
-	}
-
 	fqdn, err := utils.GetFqdn(args)
 	if err != nil {
 		return err

mgradm/cmd/migrate/podman/utils.go

@@ -30,18 +30,18 @@ func migrateToPodman(
 		return err
 	}
 
-	authFile, cleaner, err := podman_utils.PodmanLogin(hostData, flags.Installation.SCC, flags.Image)
-	if err != nil {
-		return utils.Errorf(err, L("failed to login to registry.suse.com"))
-	}
-	defer cleaner()
-
 	flags.ServerFlags.CheckParameters()
 	flags.Installation.CheckUpgradeParameters(cmd, "podman")
 	if _, err := exec.LookPath("podman"); err != nil {
 		return errors.New(L("install podman before running this command"))
 	}
 
+	authFile, cleaner, err := podman_utils.PodmanLogin(hostData, flags.Installation.SCC, flags.Image)
+	if err != nil {
+		return utils.Errorf(err, L("failed to login to registry.suse.com"))
+	}
+	defer cleaner()
+
 	return podman.Migrate(
 		systemd, authFile,
 		flags.Image.Registry,

mgradm/cmd/upgrade/podman/utils.go

@@ -24,18 +24,18 @@ func upgradePodman(_ *types.GlobalFlags, flags *podmanUpgradeFlags, cmd *cobra.C
 		return err
 	}
 
-	authFile, cleaner, err := shared_podman.PodmanLogin(hostData, flags.Installation.SCC, flags.Image)
-	if err != nil {
-		return utils.Errorf(err, L("failed to login to registry.suse.com"))
-	}
-	defer cleaner()
-
 	flags.ServerFlags.CheckParameters()
 	flags.Installation.CheckUpgradeParameters(cmd, "podman")
 	if _, err := exec.LookPath("podman"); err != nil {
 		return errors.New(L("install podman before running this command"))
 	}
 
+	authFile, cleaner, err := shared_podman.PodmanLogin(hostData, flags.Installation.SCC, flags.Image)
+	if err != nil {
+		return utils.Errorf(err, L("failed to login to registry.suse.com"))
+	}
+	defer cleaner()
+
 	return podman.Upgrade(
 		systemd, authFile,
 		flags.Image.Registry,