Add support for infered file names

When using "mgrctl cp file server:file" we always had to specify
filename.
This commit inders the filename in case of "mgrctl cp file server:"
Similarly when copying into the directory when path ends with "/".

Author: aaannz

shared/connection.go

@@ -398,6 +398,13 @@ func (c *Connection) Copy(src string, dst string, user string, group string) err
 		namespacePrefix = namespace + "/"
 	}
 
+	srcPath := strings.Replace(src, "server:", "", 1)
+	// Assume the same name as the source if we use copy with just "server:""
+	// Similarly if we copy to the directory "something/"
+	if strings.HasSuffix(dst, ":") || strings.HasSuffix(dst, "/") {
+		dst += filepath.Base(srcPath)
+	}
+
 	var commandArgs []string
 	extraArgs := []string{}
 	srcExpanded := strings.Replace(src, "server:", namespacePrefix+podName+":", 1)

shared/connection_test.go

@@ -166,6 +166,44 @@ func TestHostCopy(t *testing.T) {
 	}
 }
 
+func TestHostInferredCopy(t *testing.T) {
+	originalRunner := runner
+	defer func() { runner = originalRunner }()
+
+	var capturedCommand string
+	var capturedArgs []string
+
+	runner = func(command string, args ...string) types.Runner {
+		capturedCommand = command
+		capturedArgs = args
+		return &mockRunner{}
+	}
+
+	cnx := NewConnection("host", "", "")
+	err := cnx.Copy("server:/home/myfile", "/tmp/", "", "")
+
+	if err != nil {
+		t.Errorf("Copy returned error: %v", err)
+	}
+
+	if capturedCommand != "cp" {
+		t.Errorf("Expected command 'cp', got '%s'", capturedCommand)
+	}
+
+	if capturedArgs[0] != "/home/myfile" || capturedArgs[1] != "/tmp/myfile" {
+		t.Errorf("Expected args ['/home/myfile', '/tmp/myfile'], got %v", capturedArgs)
+	}
+
+	err = cnx.Copy("/tmp/myanotherfile", "server:", "", "")
+	if err != nil {
+		t.Errorf("Copy returned error: %v", err)
+	}
+
+	if capturedArgs[0] != "/tmp/myanotherfile" || capturedArgs[1] != "myanotherfile" {
+		t.Errorf("Expected args ['/tmp/myanotherfile', 'myanotherfile'], got %v", capturedArgs)
+	}
+}
+
 func TestHostUserExec(t *testing.T) {
 	originalRunner := runner
 	defer func() { runner = originalRunner }()