Review fixes

Author: aaannz

shared/connection.go

@@ -320,7 +320,8 @@ func (c *Connection) Healthcheck() ([]byte, error) {
 	}
 
 	if cmd == "host" {
-		return nil, errors.New(L("healthcheck not supported on host"))
+		// Healthcheck not supported on host, always return nil
+		return nil, nil
 	}
 
 	cmdArgs := []string{"healthcheck", "run", c.podName}
@@ -399,7 +400,7 @@ func (c *Connection) Copy(src string, dst string, user string, group string) err
 	}
 
 	srcPath := strings.Replace(src, "server:", "", 1)
-	// Assume the same name as the source if we use copy with just "server:""
+	// Assume the same name as the source if we use copy with just "server:"
 	// Similarly if we copy to the directory "something/"
 	if strings.HasSuffix(dst, ":") || strings.HasSuffix(dst, "/") {
 		dst += filepath.Base(srcPath)
@@ -448,7 +449,7 @@ func (c *Connection) Copy(src string, dst string, user string, group string) err
 		if command == "kubectl" {
 			execArgs = append(execArgs, "-n", namespace)
 		}
-		if command == "host" {
+		if c.backend == "host" {
 			execArgs = []string{owner, dstPath}
 			command = "chown"
 		} else {

shared/connection_test.go

@@ -190,6 +190,10 @@ func TestHostInferredCopy(t *testing.T) {
 		t.Errorf("Expected command 'cp', got '%s'", capturedCommand)
 	}
 
+	if len(capturedArgs) < 2 {
+		t.Fatal("Unexpected number of captured args")
+	}
+
 	if capturedArgs[0] != "/home/myfile" || capturedArgs[1] != "/tmp/myfile" {
 		t.Errorf("Expected args ['/home/myfile', '/tmp/myfile'], got %v", capturedArgs)
 	}
@@ -199,6 +203,10 @@ func TestHostInferredCopy(t *testing.T) {
 		t.Errorf("Copy returned error: %v", err)
 	}
 
+	if len(capturedArgs) < 2 {
+		t.Fatal("Unexpected number of captured args")
+	}
+
 	if capturedArgs[0] != "/tmp/myanotherfile" || capturedArgs[1] != "myanotherfile" {
 		t.Errorf("Expected args ['/tmp/myanotherfile', 'myanotherfile'], got %v", capturedArgs)
 	}