Fix Go version discovery on Ubuntu versions

Author: deneb-alpha

uyuni-tools.spec

@@ -82,13 +82,13 @@ BuildRequires:  golang(API) >= 1.25
 # suse_version
 
 %if 0%{?ubuntu}
-%if 0%{?ubuntu} >= 2404
-# Will use the default golang of the OS which is higher than minimal required go_version
-BuildRequires:  golang
-%else
-# Overwrite with new go version the OS default
 %define go_version      1.22
-BuildRequires:  golang-%{go_version}
+# On Ubuntu 22.04, the metapackage golang is too old (1.18) and
+# we must use the versioned package name specifically for this OS version.
+%if 0%{?ubuntu} == 2204
+BuildRequires:  golang-%{go_version}-go
+%else
+BuildRequires:  golang >= %{go_version}
 %endif
 %endif
 # ubuntu
@@ -330,15 +330,66 @@ go_tags=""
 
 go_path=""
 %if 0%{?ubuntu}
-  if test -d /usr/lib/go-%{go_version}/bin/; then
-    go_path=/usr/lib/go-%{go_version}/bin/
+  max_major=0
+  max_minor=0
+  max_patch=0
+  max_ver_str="none"
+  # Loop through all versioned paths and the system path to find the absolute maximum
+  for check_bin in /usr/lib/go-*/bin/go /usr/bin/go; do
+    if [ -x "$check_bin" ]; then
+      # Query the binary for its version (e.g., go1.22.1)
+      raw_v=$("$check_bin" env GOVERSION 2>/dev/null)
+      v_str="${raw_v#go}"
+      # Split into integers
+      cur_major="${v_str%%.*}"
+      cur_minor_full="${v_str#*.}"
+      cur_minor="${cur_minor_full%%.*}"
+
+      cur_patch=0
+      if [ "$cur_minor_full" != "$cur_minor" ]; then
+        cur_patch_full="${cur_minor_full#*.}"
+        cur_patch="${cur_patch_full%%.*}"
+      fi
+
+      # Comparison logic across found versions
+      is_newer=0
+      if [ "$cur_major" -gt "$max_major" ]; then
+        is_newer=1
+      elif [ "$cur_major" -eq "$max_major" ]; then
+        if [ "$cur_minor" -gt "$max_minor" ]; then
+          is_newer=1
+        elif [ "$cur_minor" -eq "$max_minor" ] && [ "$cur_patch" -gt "$max_patch" ]; then
+          is_newer=1
+        fi
+      fi
+
+      if [ "$is_newer" -eq 1 ]; then
+        max_major=$cur_major
+        max_minor=$cur_minor
+        max_patch=$cur_patch
+        max_ver_str="$v_str"
+        go_path="${check_bin%go}"
+      fi
+    fi
+  done
+
+  # Check that the Go compiler we found is new enough
+  req_ver="%{go_version}"
+  req_major="${req_ver%%.*}"
+  req_minor_full="${req_ver#*.}"
+  req_minor="${req_minor_full%%.*}"
+  if [ "$max_ver_str" = "none" ]; then
+    echo "ERROR: No Go compiler found in /usr/lib/go-*/bin or /usr/bin/go"
+    exit 1
+  fi
+  if [ "$max_major" -lt "$req_major" ] || { [ "$max_major" -eq "$req_major" ] && [ "$max_minor" -lt "$req_minor" ]; }; then
+    echo "ERROR: Highest found Go version is ${max_ver_str}, but version >= %{go_version} is required."
+    exit 1
   fi
 %else
   %if "%{?_go_bin}" != ""
     go_path='%{_go_bin}/'
   %endif
-# "_go_bin" != ""
-
 %endif
 # ubuntu