Skip to content

Commit 7b349ac

Browse files
authored
Merge pull request #616 from aaannz/cert_fqdn_fix
Use FQDN of the source to generate certificates during migration
2 parents 2a17292 + 2d7ab6e commit 7b349ac

2 files changed

Lines changed: 11 additions & 8 deletions

File tree

mgradm/shared/podman/podman.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,11 @@ func Upgrade(
323323
return utils.Errorf(err, L("cannot setup network"))
324324
}
325325

326+
fqdn, err := utils.GetFqdn([]string{})
327+
if err != nil {
328+
return err
329+
}
330+
326331
preparedServerImage, preparedPgsqlImage, err := podman.PrepareImages(authFile, image, pgsqlFlags)
327332
if err != nil {
328333
return utils.Errorf(err, L("cannot prepare images"))
@@ -360,7 +365,7 @@ func Upgrade(
360365
newPgVersion, oldPgVersion)
361366

362367
if err := configureSplitDBContainer(
363-
preparedServerImage, preparedPgsqlImage, systemd, db, reportdb, ssl, tz); err != nil {
368+
preparedServerImage, preparedPgsqlImage, systemd, db, reportdb, ssl, tz, fqdn); err != nil {
364369
return utils.Errorf(err, L("cannot configure db container"))
365370
}
366371
}
@@ -564,7 +569,7 @@ func Migrate(
564569
}
565570

566571
if err := configureSplitDBContainer(
567-
preparedServerImage, preparedPgsqlImage, systemd, db, reportdb, ssl, tz); err != nil {
572+
preparedServerImage, preparedPgsqlImage, systemd, db, reportdb, ssl, tz, sourceFqdn); err != nil {
568573
return utils.Errorf(err, L("cannot configure db container"))
569574
}
570575

@@ -819,13 +824,9 @@ func configureSplitDBContainer(
819824
reportdb adm_utils.DBFlags,
820825
ssl adm_utils.InstallSSLFlags,
821826
tz string,
827+
fqdn string,
822828
) error {
823-
fqdn, err := utils.GetFqdn([]string{})
824-
if err != nil {
825-
return err
826-
}
827-
828-
if err = PrepareSSLCertificates(serverImage, &ssl, tz, fqdn); err != nil {
829+
if err := PrepareSSLCertificates(serverImage, &ssl, tz, fqdn); err != nil {
829830
return err
830831
}
831832

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- Use FQDN of the source to generate certificates during migration
2+
(bsc#1244847)

0 commit comments

Comments
 (0)