You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Then, if the change is API-visible: update Pothos types/resolvers (`klicker-graphql-api`) — the Pothos Prisma plugin picks up new fields, but object types expose them explicitly.
20
20
21
+
Run Prisma client generation only through `pnpm --filter @klicker-uzh/prisma generate` (or a build that calls it). The package script owns the TypeScript 6 generated-namespace patch; direct `prisma generate` bypasses it. The package's canonical `check` includes the patch invariant tests. If generation fails at the patch, run `pnpm --filter @klicker-uzh/prisma test:patch-namespace` and inspect the new generated declarations instead of weakening the exact-cardinality guard.
22
+
21
23
Provenance: steps 2 requires a database; on a machine without one running, write the schema change and STOP — hand the migration step to the user rather than faking a migration file.
Copy file name to clipboardExpand all lines: .agents/skills/klicker-testing-verification/SKILL.md
+5-3Lines changed: 5 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -18,7 +18,7 @@ Facts about the test landscape: [docs/testing.md](../../../docs/testing.md). Thi
18
18
19
19
Never run root `pnpm run test:run` blind — its turbo fan-out includes Cypress, which needs a running seeded stack.
20
20
21
-
Direct checks for `auth`, `chat`, `frontend-control`, `frontend-manage`, and `frontend-pwa` generate ignored Next route types first through each app's `check` script. Do not hand-edit or commit `next-env.d.ts`; keep it ignored and included by `tsconfig.json`. The three PWA apps use `tsconfig.check.json`to exclude `.next/dev/types`from raw `tsc`; otherwise stale dev and fresh production Pages Router validators duplicate global declarations.
21
+
Direct checks for `auth`, `chat`, `frontend-control`, `frontend-manage`, and `frontend-pwa` generate ignored Next route types first through each app's `check` script. Do not hand-edit or commit `next-env.d.ts`; keep it ignored and included by `tsconfig.json`. The three PWA apps use `tsconfig.check.json`only for raw package checks so stale `.next/dev/types`cannot duplicate fresh Pages Router validators. Next builds use the canonical `tsconfig.json`; Next 16 filters development validators on its production typecheck path. Auth and Chat use their main config for both checks and builds.
22
22
23
23
For Next framework or bundler changes, verify both repository-supported paths. `pnpm run build:test` uses Turbopack in all five Next apps. `pnpm run build` uses Turbopack for auth/chat and Webpack for control/manage/PWA until their service-worker integration moves to Serwist. Confirm standalone server paths for all five apps and `sw.js`, Workbox, and custom worker outputs for the three PWA apps.
24
24
@@ -36,12 +36,14 @@ CI runs Cypress (8-way split) and Playwright (8-way shard) on almost every code
36
36
37
37
Every item, in order; paste evidence (command + tail of output, screenshots) into the PR or task report:
38
38
39
-
1.`pnpm run check:all` — typecheck + format + lint + syncpack (same as pre-commit hook).
39
+
1.`pnpm run check:all` — typecheck + format + lint + syncpack + AGENTS.md validation + Prisma-sync validation (same as pre-commit hook). The Prisma package check regenerates its client before typechecking, so it is safe from a clean checkout.
40
40
2.`pnpm run build` — same as pre-push hook; also refreshes generated artifacts.
41
41
3. Targeted tests per the routing table above — quote failures exactly; never delete/weaken a test to pass.
42
42
4.**Codegen artifacts committed** if any `.graphql` op or schema changed (`git status` must be clean after `pnpm --filter @klicker-uzh/graphql generate`).
43
43
5.**i18n pair check** if UI text changed: the key exists in BOTH `packages/i18n/messages/de.ts` and `en.ts`.
44
-
6.**Browser evidence for UI changes** — open the changed pages with `npx agent-browser` (never bare `agent-browser`), log in with delegated/test credentials (AGENTS.md), capture before/after screenshots. "The logic looks correct" does not count.
44
+
6.**Browser evidence for UI changes** — open the changed pages with `npx agent-browser@0.32.2` (never bare `agent-browser`), log in with delegated/test credentials (AGENTS.md), capture before/after screenshots. "The logic looks correct" does not count.
45
+
46
+
For TypeScript or other compiler/toolchain upgrades, root `check:all` includes the Cypress and Playwright compilers through their package `check` scripts. Also run `pnpm run build:test` and the Docs production build; those surfaces remain outside the root check. Use direct package `tsc --noEmit -p tsconfig.json` commands only to isolate a Cypress or Playwright failure. When a check config extends a declaration-emitting config, verify the resolved compiler options: `noEmit` does not disable declaration portability analysis, so the check may also need explicit `declaration: false` and `declarationMap: false`. Incremental checks must use a different `tsBuildInfoFile` from the emitting build.
0 commit comments