refactor(kb): simplify wiring and reduce redundant fetches

- Add safePrompt/safeConfirm helpers to packages/kb-management/src/utils
  and use them in KB sidebar, resource inspector and settings view
  (removes 5 inline SSR guards).
- Drive the linked-courses and linked-chatbots panels in the KB
  settings view from a single LINKED_CONSUMER_PANELS config entry
  (eliminates the near-duplicate Panel block).
- Replace getOwnedKBOrThrow precheck with the lightweight assertOwnedKB
  in getKBResources, getKBIngestionRuns, deleteKB, updateKBRefreshPolicy,
  linkKBCourse, unlinkKBCourse, linkKBChatbot and unlinkKBChatbot
  (drops the wasted KB_INCLUDE round-trip when only ownership matters).
- Run kbListQuery and selectedKbQuery refetches in parallel inside
  apps/frontend-kb runMutation.
- Tighten the linkKBChatbot guard comment to a single sentence.

Author: rschlaefli

apps/frontend-kb/src/pages/index.tsx

@@ -95,10 +95,12 @@ function KbHomePage() {
   }, [kbListQuery.data?.getKBs, selectedKnowledgeBaseId])
 
   const refetchKBs = async () => {
-    await kbListQuery.refetch()
-    if (selectedKnowledgeBaseId) {
-      await selectedKbQuery.refetch({ id: selectedKnowledgeBaseId })
-    }
+    await Promise.all([
+      kbListQuery.refetch(),
+      selectedKnowledgeBaseId
+        ? selectedKbQuery.refetch({ id: selectedKnowledgeBaseId })
+        : Promise.resolve(),
+    ])
   }
 
   const selectedKnowledgeBaseSummary =

packages/graphql/src/services/knowledge.ts

@@ -526,7 +526,7 @@ export async function getKBResources(
   { kbId, filter }: { kbId: string; filter?: KBResourceFilterInput | null },
   ctx: ContextWithUser
 ) {
-  await getOwnedKBOrThrow(kbId, ctx)
+  await assertOwnedKB(kbId, ctx)
 
   return await ctx.prisma.kBResource.findMany({
     where: {
@@ -556,7 +556,7 @@ export async function getKBIngestionRuns(
   }: { kbId: string; resourceId?: string | null; limit?: number | null },
   ctx: ContextWithUser
 ) {
-  await getOwnedKBOrThrow(kbId, ctx)
+  await assertOwnedKB(kbId, ctx)
 
   return await ctx.prisma.kBIngestionRun.findMany({
     where: { kbId, resourceId: resourceId ?? undefined },
@@ -670,7 +670,7 @@ export async function updateKB(
 }
 
 export async function deleteKB({ id }: { id: string }, ctx: ContextWithUser) {
-  await getOwnedKBOrThrow(id, ctx)
+  await assertOwnedKB(id, ctx)
   const activeResources = await ctx.prisma.kBResource.findMany({
     where: { kbId: id, deletedAt: null },
     include: RESOURCE_INCLUDE,
@@ -848,7 +848,7 @@ export async function updateKBRefreshPolicy(
   { kbId, input }: { kbId: string; input: UpdateKBRefreshPolicyInput },
   ctx: ContextWithUser
 ) {
-  await getOwnedKBOrThrow(kbId, ctx)
+  await assertOwnedKB(kbId, ctx)
   const policy = validateKBRefreshPolicy(input)
   return await ctx.prisma.kB.update({
     where: { id: kbId },
@@ -877,7 +877,7 @@ export async function linkKBCourse(
   { kbId, courseId }: { kbId: string; courseId: string },
   ctx: ContextWithUser
 ) {
-  await getOwnedKBOrThrow(kbId, ctx)
+  await assertOwnedKB(kbId, ctx)
   const course = await ctx.prisma.course.findFirst({
     where: { id: courseId, ownerId: ctx.user.sub },
     select: { id: true },
@@ -897,7 +897,7 @@ export async function unlinkKBCourse(
   { kbId, courseId }: { kbId: string; courseId: string },
   ctx: ContextWithUser
 ) {
-  await getOwnedKBOrThrow(kbId, ctx)
+  await assertOwnedKB(kbId, ctx)
   await ctx.prisma.kBCourse.deleteMany({ where: { kbId, courseId } })
   return await getOwnedKBOrThrow(kbId, ctx)
 }
@@ -916,17 +916,15 @@ export async function linkKBChatbot(
   },
   ctx: ContextWithUser
 ) {
-  await getOwnedKBOrThrow(kbId, ctx)
+  await assertOwnedKB(kbId, ctx)
   const chatbot = await ctx.prisma.chatbot.findFirst({
     where: { id: chatbotId, ownerId: ctx.user.sub },
     select: { id: true },
   })
   if (!chatbot) throw new Error('Chatbot not found')
 
-  // Enforce KB_PLAN.md decision #7: max one enabled KB per chatbot. When
-  // enabling this link (default on create, explicit `true` on update), demote
-  // every other enabled link for the same chatbot in the same transaction so
-  // there is never a window with two active KBs.
+  // KB_PLAN.md decision #7: at most one enabled KB per chatbot. No DB-level
+  // partial unique index, so demote any other enabled rows in the same txn.
   const willEnable = isEnabled !== false
   await ctx.prisma.$transaction([
     ...(willEnable
@@ -963,7 +961,7 @@ export async function unlinkKBChatbot(
   { kbId, chatbotId }: { kbId: string; chatbotId: string },
   ctx: ContextWithUser
 ) {
-  await getOwnedKBOrThrow(kbId, ctx)
+  await assertOwnedKB(kbId, ctx)
   await ctx.prisma.kBChatbot.deleteMany({ where: { kbId, chatbotId } })
   return await getOwnedKBOrThrow(kbId, ctx)
 }

packages/kb-management/src/components/KnowledgeBaseSettingsView.tsx

@@ -11,7 +11,7 @@ import type {
   LinkedConsumer,
   UpdateKnowledgeBaseInput,
 } from '../types.js'
-import { getRefreshPolicyLabel } from '../utils.js'
+import { getRefreshPolicyLabel, safePrompt } from '../utils.js'
 
 interface KnowledgeBaseSettingsViewProps {
   knowledgeBase?: KnowledgeBaseSummary
@@ -242,51 +242,35 @@ export function KnowledgeBaseSettingsView({
           </Panel>
         )}
 
-        {(onLinkCourse || onUnlinkCourse) && (
-          <Panel
-            title="Linked courses"
-            description="Courses that use this knowledge base"
-          >
-            <LinkedConsumerList
-              items={knowledgeBase.linkedCourses}
-              promptLabel="Course ID"
-              addLabel="Link course"
-              onLink={
-                onLinkCourse
-                  ? (courseId) => onLinkCourse(knowledgeBase.id, courseId)
-                  : undefined
-              }
-              onUnlink={
-                onUnlinkCourse
-                  ? (courseId) => onUnlinkCourse(knowledgeBase.id, courseId)
-                  : undefined
-              }
-            />
-          </Panel>
-        )}
+        {LINKED_CONSUMER_PANELS.map((panel) => {
+          const link = panel.kind === 'course' ? onLinkCourse : onLinkChatbot
+          const unlink =
+            panel.kind === 'course' ? onUnlinkCourse : onUnlinkChatbot
+          if (!link && !unlink) return null
 
-        {(onLinkChatbot || onUnlinkChatbot) && (
-          <Panel
-            title="Linked chatbots"
-            description="Chatbots that consume this knowledge base"
-          >
-            <LinkedConsumerList
-              items={knowledgeBase.linkedChatbots}
-              promptLabel="Chatbot ID"
-              addLabel="Link chatbot"
-              onLink={
-                onLinkChatbot
-                  ? (chatbotId) => onLinkChatbot(knowledgeBase.id, chatbotId)
-                  : undefined
-              }
-              onUnlink={
-                onUnlinkChatbot
-                  ? (chatbotId) => onUnlinkChatbot(knowledgeBase.id, chatbotId)
-                  : undefined
-              }
-            />
-          </Panel>
-        )}
+          const items =
+            panel.kind === 'course'
+              ? knowledgeBase.linkedCourses
+              : knowledgeBase.linkedChatbots
+
+          return (
+            <Panel
+              key={panel.kind}
+              title={panel.title}
+              description={panel.description}
+            >
+              <LinkedConsumerList
+                items={items}
+                promptLabel={panel.promptLabel}
+                addLabel={panel.addLabel}
+                onLink={link ? (id) => link(knowledgeBase.id, id) : undefined}
+                onUnlink={
+                  unlink ? (id) => unlink(knowledgeBase.id, id) : undefined
+                }
+              />
+            </Panel>
+          )
+        })}
       </div>
     </div>
   )
@@ -352,6 +336,23 @@ function KnowledgeBaseDetailsForm({
   )
 }
 
+const LINKED_CONSUMER_PANELS = [
+  {
+    kind: 'course' as const,
+    title: 'Linked courses',
+    description: 'Courses that use this knowledge base',
+    promptLabel: 'Course ID',
+    addLabel: 'Link course',
+  },
+  {
+    kind: 'chatbot' as const,
+    title: 'Linked chatbots',
+    description: 'Chatbots that consume this knowledge base',
+    promptLabel: 'Chatbot ID',
+    addLabel: 'Link chatbot',
+  },
+]
+
 function LinkedConsumerList({
   items,
   promptLabel,
@@ -365,19 +366,18 @@ function LinkedConsumerList({
   onLink?: (id: string) => void
   onUnlink?: (id: string) => void
 }) {
+  const list = items ?? []
   const handleAdd = () => {
     if (!onLink) return
-    const id = typeof window === 'undefined' ? null : window.prompt(promptLabel)
+    const id = safePrompt(promptLabel)
     if (!id) return
     onLink(id)
   }
 
   return (
     <div className="space-y-2">
-      {(items ?? []).length === 0 && (
-        <EmptySetting>None linked yet.</EmptySetting>
-      )}
-      {(items ?? []).map((item) => (
+      {list.length === 0 && <EmptySetting>None linked yet.</EmptySetting>}
+      {list.map((item) => (
         <div
           key={item.id}
           className="flex items-center justify-between gap-2 rounded-md border border-slate-200 bg-white p-2 text-sm"

packages/kb-management/src/components/KnowledgeBaseSidebar.tsx

@@ -7,6 +7,7 @@ import type {
   KnowledgeMetadataFieldDefinition,
   UpdateKnowledgeBaseInput,
 } from '../types.js'
+import { safeConfirm, safePrompt } from '../utils.js'
 import { MetadataChips } from './MetadataChips.js'
 import { StatusBadge } from './StatusBadge.js'
 
@@ -36,32 +37,21 @@ export function KnowledgeBaseSidebar({
 }: KnowledgeBaseSidebarProps) {
   const handleCreate = () => {
     if (!onCreateKnowledgeBase) return
-    const name =
-      typeof window === 'undefined'
-        ? null
-        : window.prompt('Knowledge base name')
+    const name = safePrompt('Knowledge base name')
     if (!name) return
     onCreateKnowledgeBase({ name })
   }
 
   const handleRename = (kb: KnowledgeBaseSummary) => {
     if (!onUpdateKnowledgeBase) return
-    const name =
-      typeof window === 'undefined'
-        ? null
-        : window.prompt('Rename knowledge base', kb.name)
+    const name = safePrompt('Rename knowledge base', kb.name)
     if (!name || name === kb.name) return
     onUpdateKnowledgeBase(kb.id, { name })
   }
 
   const handleDelete = (kb: KnowledgeBaseSummary) => {
     if (!onDeleteKnowledgeBase) return
-    if (
-      typeof window !== 'undefined' &&
-      !window.confirm(`Delete "${kb.name}"? This cannot be undone.`)
-    ) {
-      return
-    }
+    if (!safeConfirm(`Delete "${kb.name}"? This cannot be undone.`)) return
     onDeleteKnowledgeBase(kb.id)
   }
   return (

packages/kb-management/src/components/ResourceInspector.tsx

@@ -13,6 +13,7 @@ import {
   DEFAULT_RESOURCE_TYPES,
   getRefreshPolicyLabel,
   getResourceTypeDefinition,
+  safePrompt,
 } from '../utils.js'
 import { ActivityPanels } from './ActivityPanels.js'
 import { MetadataChips } from './MetadataChips.js'
@@ -60,10 +61,7 @@ export function ResourceInspector({
 }: ResourceInspectorProps) {
   const handleRename = () => {
     if (!resource || !onUpdateResource) return
-    const title =
-      typeof window === 'undefined'
-        ? null
-        : window.prompt('Resource title', resource.title)
+    const title = safePrompt('Resource title', resource.title)
     if (!title || title === resource.title) return
     onUpdateResource(resource.id, { title })
   }

packages/kb-management/src/utils.ts

@@ -216,6 +216,19 @@ export function filterKnowledgeResources(
   })
 }
 
+export function safePrompt(
+  message: string,
+  defaultValue?: string
+): string | null {
+  if (typeof window === 'undefined') return null
+  return window.prompt(message, defaultValue)
+}
+
+export function safeConfirm(message: string): boolean {
+  if (typeof window === 'undefined') return false
+  return window.confirm(message)
+}
+
 export function getRefreshPolicyLabel(policy?: KnowledgeRefreshPolicy) {
   if (!policy) return 'Manual'
   if (policy.label) return policy.label