fix: reset grid column width when setWidth(null) is called#9738
Closed
web-padawan wants to merge 2 commits into
Closed
fix: reset grid column width when setWidth(null) is called#9738web-padawan wants to merge 2 commits into
web-padawan wants to merge 2 commits into
Conversation
Column.setWidth(null) set the width property to null instead of removing it, which caused the column to render with a very large width. Now a null width removes the property so the column falls back to its default width. Co-authored-by: Serhii Kulykov <10589913+web-padawan@users.noreply.github.com>
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
|
sissbruecker
approved these changes
Jul 14, 2026
Member
Author
|
Looks like this might not be a proper fix. The issue is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Column.setWidth(null)set the web component'swidthproperty tonullinstead of removing it, causing the column to render with a very large width rather than its default. Now anullwidth removes the property.Fixes #6811
🤖 Generated with Claude Code