… + valid_tools Per review (#78), the per-mech `Dict[address, List[tool]]` shape doesn't buy anything the two stated requirements (which mechs are eligible / which tools are eligible) don't get from two flat sets. The "different mechs offer different tools" reality is already encoded in each mech's IPFS manifest, so per-mech config only carries an (allowed-mech, allowed-tool) constraint we don't actually have. Changes: - Replace `valid_mech_tools: Dict[str, List[str]]` with two flat params: `valid_mechs: List[str]` (lowercased on load, allowlist for the marketplace subgraph) and `valid_tools: List[str]` (intersected with each mech's IPFS tool manifest). - Drop `_normalize_valid_mech_tools` helper and `valid_mech_addresses` derived property: `valid_mechs` is now the source. - `populate_tools` intersects `(metadata_tools - irrelevant_tools) & valid_tools` once outside the per-mech loop instead of a per-address dict lookup. - Subgraph query template var `${valid_mech_addresses}` renamed to `${valid_mechs}` to match the new param name. Review-comment fixes also folded in: - Add a startup warning when marketplace v2 dynamic selection is enabled but `valid_mechs` is empty, so misconfig surfaces at boot rather than after the first failed round (LOCKhart #2). - Split `valid_mech_list_empty` into two reasons: `allowlist_not_configured` when `valid_mechs` is empty, `valid_mech_list_empty` when the subgraph returned nothing matching a configured allowlist (LOCKhart #3). - Rename the per-mech-tool exhaustion reason to `no_overlap_with_valid_tools` to match the new flat shape. - Remove the dual-write of `valid_mech_addresses` in request behaviour tests; the property is gone and tests now drive `valid_mechs` directly (LOCKhart #5). - Document the breaking change and new params in UPGRADING.md (LOCKhart #1). Tests: - Drop `TestNormalizeValidMechTools` (helper removed). - Drop `TestAllowlistIntersect.test_drops_address_not_in_allowlist` and `test_address_lookup_is_case_insensitive`: address-level filtering now happens at the subgraph layer, not in `populate_tools`. Add `test_empty_valid_tools_yields_empty_relevant_tools`. - `TestLastFailureReason` rewritten for the split reasons + `no_overlap_with_valid_tools`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Uh oh!

Add balance check when building the tx to purchase a subscription #5

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions