fix(mech): scrub two review nits — sibling comment drift + phantom class

Aligns the ``task_submission_abci/models.py`` comment on ``use_offchain``
with its sibling in ``task_execution/models.py``. The old wording still
claimed "no coherent state where ingress and egress diverge", which
directly contradicts the divergence safety net just added in
``_do_predict_api_write_best_effort``. New wording matches the
task_execution rewrite: coupling is deliberate, drift between the two
skill copies IS possible via env override, and the WARNING gate is
what surfaces that drift.

Renames ``FetchDataBehaviour`` → ``TaskExecutionBehaviour`` in the four
new docstrings on the ingress-gate tests. ``FetchDataBehaviour`` isn't a
real class in this repo — the ``behaviour`` conftest fixture is a
``TaskExecutionBehaviour``. Copy-paste artifact.

Author: DIvyaNautiyal07

packages/packages.json

@@ -9,12 +9,12 @@
         "connection/valory/websocket_client/0.1.0": "bafybeid4cnbjpmzcsw3usg7umufgqyod2u3xfw5uso3vukt3n5hfuxvdea",
         "skill/valory/contract_subscription/0.1.0": "bafybeicqlkmfpttw4hbbaakr6xos62rd6ytjwkyzlfli4xpvl5yqcycf6q",
         "skill/valory/delivery_rate_abci/0.1.0": "bafybeiathwdfpcfqbipqbkslv6j22q5cvov4n3czmehzij3czrhdnlg42e",
-        "skill/valory/mech_abci/0.1.0": "bafybeigvomrayvkwvativspmvgwdveqiqyndqlteluv235jigd6xgrdlsa",
-        "skill/valory/task_execution/0.1.0": "bafybeided62jostve2n5b4c7fsccxf4wce4ld3rbvalfdbqp77euon5rtq",
-        "skill/valory/task_submission_abci/0.1.0": "bafybeiblfzy23r3bgcfdceeoilz2fiqscdyrer3b2xewctq77tlnkja5fa",
+        "skill/valory/mech_abci/0.1.0": "bafybeiatxn2wb7pasde63hi4cghzoxzr6thj2xe3zwllr54f4kjx7b4ciq",
+        "skill/valory/task_execution/0.1.0": "bafybeies2iytb73xae2t7k53ap4nzfdfvyqrglofjzdduv5ck4ptanxsjy",
+        "skill/valory/task_submission_abci/0.1.0": "bafybeibdegmyw2pq54byeac7izj7vcm6egzhj6d72di7s3xdt3pfmai22i",
         "skill/valory/websocket_client/0.1.0": "bafybeid6oyycsrvk4duftffs5mrfgmcepibt3qe4om3kfzhwhilfq3ynay",
-        "agent/valory/mech/0.1.0": "bafybeifg32fr5cf7enk2owgtjyn7rdr5o6goinfdgmsg2lod5amhu6dfjy",
-        "service/valory/mech/0.1.0": "bafybeifgey2wtnotht4aj6yuwb4rsxsofolhadrqvh6yylstcxphu3d4sy"
+        "agent/valory/mech/0.1.0": "bafybeidos57xj77zosblpmu2hsxkhczvotjwyxw2gwzhlumh3r6y7cyyxa",
+        "service/valory/mech/0.1.0": "bafybeig5rxdfzpxvfheh6nvd5wnpkmktrfpzytefo6db66pwkvnpum7myi"
     },
     "third_party": {
         "protocol/open_aea/signing/1.0.0": "bafybeifsjmldwyki3beqyvdt5lzenrg6wyrqaar5plc5rpnvtc4zlentye",

packages/valory/agents/mech/aea-config.yaml

@@ -40,12 +40,12 @@ skills:
 - valory/abstract_abci:0.1.0:bafybeie5et43th2nta76cd3kpm3fmurd7oyzk3qxim76octvt56m6r2poi
 - valory/abstract_round_abci:0.1.0:bafybeifkxnvvgsldkb4rgejsoon2mvrmrnl7asy2nhenwss7hpwg3myflu
 - valory/contract_subscription:0.1.0:bafybeicqlkmfpttw4hbbaakr6xos62rd6ytjwkyzlfli4xpvl5yqcycf6q
-- valory/mech_abci:0.1.0:bafybeigvomrayvkwvativspmvgwdveqiqyndqlteluv235jigd6xgrdlsa
+- valory/mech_abci:0.1.0:bafybeiatxn2wb7pasde63hi4cghzoxzr6thj2xe3zwllr54f4kjx7b4ciq
 - valory/registration_abci:0.1.0:bafybeif4n2esdjvquomdkwktv7eolepskpo5jlqrfda2abxjqzy2ljsxzi
 - valory/reset_pause_abci:0.1.0:bafybeifrnmlscfiki7wojs6zasppefupd2wkjyq6orhdllfppjud7isrxi
 - valory/delivery_rate_abci:0.1.0:bafybeiathwdfpcfqbipqbkslv6j22q5cvov4n3czmehzij3czrhdnlg42e
-- valory/task_execution:0.1.0:bafybeided62jostve2n5b4c7fsccxf4wce4ld3rbvalfdbqp77euon5rtq
-- valory/task_submission_abci:0.1.0:bafybeiblfzy23r3bgcfdceeoilz2fiqscdyrer3b2xewctq77tlnkja5fa
+- valory/task_execution:0.1.0:bafybeies2iytb73xae2t7k53ap4nzfdfvyqrglofjzdduv5ck4ptanxsjy
+- valory/task_submission_abci:0.1.0:bafybeibdegmyw2pq54byeac7izj7vcm6egzhj6d72di7s3xdt3pfmai22i
 - valory/termination_abci:0.1.0:bafybeih6sa2ttcvvjk7rcfn7ure2ws23kcfufssb4qmluzcfvednkfpvoi
 - valory/transaction_settlement_abci:0.1.0:bafybeihizaapype5sz7vlosms3nfo6jzfj4ujycuf5uthviq2otvmw6f6m
 - valory/websocket_client:0.1.0:bafybeid6oyycsrvk4duftffs5mrfgmcepibt3qe4om3kfzhwhilfq3ynay

packages/valory/services/mech/service.yaml

@@ -7,7 +7,7 @@ license: Apache-2.0
 fingerprint:
   README.md: bafybeihppqns2lwn5vehtqh2wu4tjyf76dbzxc26nlfws4sc5hcbjbalma
 fingerprint_ignore_patterns: []
-agent: valory/mech:0.1.0:bafybeifg32fr5cf7enk2owgtjyn7rdr5o6goinfdgmsg2lod5amhu6dfjy
+agent: valory/mech:0.1.0:bafybeidos57xj77zosblpmu2hsxkhczvotjwyxw2gwzhlumh3r6y7cyyxa
 number_of_agents: 4
 deployment:
   agent:

packages/valory/skills/mech_abci/skill.yaml

@@ -30,11 +30,11 @@ skills:
 - valory/abstract_round_abci:0.1.0:bafybeifkxnvvgsldkb4rgejsoon2mvrmrnl7asy2nhenwss7hpwg3myflu
 - valory/registration_abci:0.1.0:bafybeif4n2esdjvquomdkwktv7eolepskpo5jlqrfda2abxjqzy2ljsxzi
 - valory/reset_pause_abci:0.1.0:bafybeifrnmlscfiki7wojs6zasppefupd2wkjyq6orhdllfppjud7isrxi
-- valory/task_submission_abci:0.1.0:bafybeiblfzy23r3bgcfdceeoilz2fiqscdyrer3b2xewctq77tlnkja5fa
+- valory/task_submission_abci:0.1.0:bafybeibdegmyw2pq54byeac7izj7vcm6egzhj6d72di7s3xdt3pfmai22i
 - valory/termination_abci:0.1.0:bafybeih6sa2ttcvvjk7rcfn7ure2ws23kcfufssb4qmluzcfvednkfpvoi
 - valory/transaction_settlement_abci:0.1.0:bafybeihizaapype5sz7vlosms3nfo6jzfj4ujycuf5uthviq2otvmw6f6m
 - valory/delivery_rate_abci:0.1.0:bafybeiathwdfpcfqbipqbkslv6j22q5cvov4n3czmehzij3czrhdnlg42e
-- valory/task_execution:0.1.0:bafybeided62jostve2n5b4c7fsccxf4wce4ld3rbvalfdbqp77euon5rtq
+- valory/task_execution:0.1.0:bafybeies2iytb73xae2t7k53ap4nzfdfvyqrglofjzdduv5ck4ptanxsjy
 behaviours:
   main:
     args: {}

packages/valory/skills/task_execution/skill.yaml

@@ -13,7 +13,7 @@ fingerprint:
   models.py: bafybeih3es32osrundnhoguzursbc4zfde7qa27zmrkepdud24jffmrycy
   tests/__init__.py: bafybeieqltdoxt2ipgn7owrfyceylzqug3fpdy6pk6mxhdxyn2mujz4v7q
   tests/conftest.py: bafybeickrspufxtr47ndp5vbrkejmwutlv4swub6ai7ngyh6ejlsulxgom
-  tests/test_behaviours.py: bafybeid4lqan22icsja5cslnwaxtiazu27bwgyjkdthkxozrr4mcziji4m
+  tests/test_behaviours.py: bafybeiezgysiwi54hbsoktrzhvktaolst4rkszyu57p7ezrjev7c3ckroa
   tests/test_dialogues.py: bafybeig2phgjrv7ugdx4olviuclaxegvyzkcw7t2ztzrp3xcj2ygqs4344
   tests/test_handlers.py: bafybeic7jdqovcajvvw5s6kgo7nlpkpkiibpwfgnctpfurunyu4f7is2yi
   tests/test_models.py: bafybeidyzmub74c3m6zopwgxy43o2mx5tvig4wmahgyhoiur4qz55jgwaq

packages/valory/skills/task_execution/tests/test_behaviours.py

@@ -3531,7 +3531,7 @@ def _finalize_gate_setup(
     lets it. ``to_multihash`` is monkeypatched to a cheap prefix so
     ``_finalize_done_task`` doesn't try to run the real multihash logic.
 
-    :param behaviour: FetchDataBehaviour fixture.
+    :param behaviour: TaskExecutionBehaviour fixture.
     :param shared_state: shared_state fixture.
     :param params_stub: params fixture.
     :param monkeypatch: pytest monkeypatch fixture used to swap
@@ -3591,7 +3591,7 @@ def test_finalize_done_task_attaches_predict_api_event_when_use_offchain_on(
     behaviour then reads off ``synchronized_data.done_tasks`` after
     consensus replication.
 
-    :param behaviour: FetchDataBehaviour fixture.
+    :param behaviour: TaskExecutionBehaviour fixture.
     :param params_stub: params fixture with ``use_offchain=True``.
     :param shared_state: shared_state fixture.
     :param monkeypatch: pytest monkeypatch fixture.
@@ -3625,7 +3625,7 @@ def test_finalize_done_task_attaches_predict_api_event_on_marketplace_delivery(
     ``source='mech_onchain'``. Regression against a docstring drift
     that was suggesting the condition was marketplace-only.
 
-    :param behaviour: FetchDataBehaviour fixture.
+    :param behaviour: TaskExecutionBehaviour fixture.
     :param params_stub: params fixture with ``use_offchain=True``.
     :param shared_state: shared_state fixture.
     :param monkeypatch: pytest monkeypatch fixture.
@@ -3658,7 +3658,7 @@ def test_finalize_done_task_omits_predict_api_event_when_use_offchain_off(
     when the flag is off. Pairs with the egress-side gate test in
     ``task_submission_abci/tests/test_onchain_write_path.py``.
 
-    :param behaviour: FetchDataBehaviour fixture.
+    :param behaviour: TaskExecutionBehaviour fixture.
     :param params_stub: params fixture, flipped to ``use_offchain=False`` here.
     :param shared_state: shared_state fixture.
     :param monkeypatch: pytest monkeypatch fixture.

packages/valory/skills/task_submission_abci/models.py

@@ -128,10 +128,20 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
         # endpoint from PostTxSettlement (settlement writes for both
         # offchain-settled AND on-chain-settled requests). A mech is
         # either part of the predict-api analytics pipeline or it isn't;
-        # there's no coherent state where ingress and egress diverge.
-        # False by default so an out-of-the-box mech does no off-mech
-        # HTTP work at settlement time and does not accept offchain
-        # requests.
+        # the coupling is deliberate. On-chain-only mechs that want
+        # analytics writes (``mech_onchain`` source) still flip this on
+        # and accept that their offchain HTTP handler is also live — the
+        # handler is inert if no client's ``MECH_OFFCHAIN_URL`` points
+        # at it, so the cost is a wire nothing rides rather than a
+        # traffic-shape change. The value is a duplicate of the flag
+        # of the same name on ``task_execution``; if the two copies
+        # drift (env override on one skill and not the other),
+        # :py:meth:`PostTxSettlementBehaviour._do_predict_api_write_best_effort`
+        # emits a WARNING when it sees ``predict_api_event`` entries
+        # under a locally-off flag, so the misconfiguration is
+        # alertable rather than silent. False by default so an
+        # out-of-the-box mech does no off-mech HTTP work at settlement
+        # time and does not accept offchain requests.
         self.use_offchain: bool = bool(kwargs.get("use_offchain", False))
         # predict-api ``POST /mech/events`` endpoint. Empty string = no
         # URL configured; the PostTxSettlement behaviour short-circuits

packages/valory/skills/task_submission_abci/skill.yaml

@@ -12,7 +12,7 @@ fingerprint:
   dialogues.py: bafybeicvqbqqviqhjkj4hfyqepanqzv6oa3nknpjaczs6yjpyxx5ilcbcq
   fsm_specification.yaml: bafybeicswghmdg7xsfhlgznsyr7zhydtunb2575qucxkxmeks6gcos3ut4
   handlers.py: bafybeieikfkrjtnlod35ldqf3veoe3oqha6fnnpqpkxwibi5jyobsnvd4a
-  models.py: bafybeifseshqkg5brosbmhlei4dnqwcmlu7r5istgj7utmsqpbgwdmjlq4
+  models.py: bafybeiegx7qustzak3oibom3yzphvismtb3cmsjlmmvmepp2p7pzsczxya
   payloads.py: bafybeiaaelmpfuv6pvuesj7iy2nnxvgxjketigrppurto2pbsoaqjum2ba
   predict_api_events_client.py: bafybeiaipvkrwitftwprsbrnj4rd6ac4n74qzvq22lscbb5li4efc2qnve
   rounds.py: bafybeifyjanb7hbqolgxsudzhr27otlaozgttjwufmqit6w5rgb2xc53yu
@@ -47,7 +47,7 @@ protocols:
 skills:
 - valory/abstract_round_abci:0.1.0:bafybeifkxnvvgsldkb4rgejsoon2mvrmrnl7asy2nhenwss7hpwg3myflu
 - valory/transaction_settlement_abci:0.1.0:bafybeihizaapype5sz7vlosms3nfo6jzfj4ujycuf5uthviq2otvmw6f6m
-- valory/task_execution:0.1.0:bafybeided62jostve2n5b4c7fsccxf4wce4ld3rbvalfdbqp77euon5rtq
+- valory/task_execution:0.1.0:bafybeies2iytb73xae2t7k53ap4nzfdfvyqrglofjzdduv5ck4ptanxsjy
 behaviours:
   main:
     args: {}