Skip to content

Commit a9c6c40

Browse files
committed
Merge branch 'hotfix/0.7.2'
2 parents 5b6aeea + 5ca38e3 commit a9c6c40

5 files changed

Lines changed: 12 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
66

77
## [Unreleased]
88

9+
## [0.7.2] - 2019-03-31
10+
11+
### Fixes
12+
- Fix minor issue with hg19 wrong blacklist url
13+
- Ensembl downloads over http instead of https (release 99 no longer has https)
14+
915
## [0.7.1] - 2019-11-20
1016

1117
### Fixes

genomepy/__about__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
"""Metadata"""
2-
__version__ = "0.7.1"
2+
__version__ = "0.7.2"
33
__author__ = "Simon van Heeringen"

genomepy/plugins/blacklist.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ class BlacklistPlugin(Plugin):
1111
"ce10": base_url + "ce10-C.elegans/ce10-blacklist.bed.gz",
1212
"dm3": base_url + "dm3-D.melanogaster/dm3-blacklist.bed.gz",
1313
"hg38": base_url + "hg38-human/hg38.blacklist.bed.gz",
14-
"hg19": base_url + "hg38-human/hg19.blacklist.bed.gz",
14+
"hg19": base_url
15+
+ "hg19-human/wgEncodeHg19ConsensusSignalArtifactRegions.bed.gz",
1516
"mm9": base_url + "mm9-mouse/mm9-blacklist.bed.gz",
1617
"mm10": base_url + "mm10-mouse/mm10.blacklist.bed.gz",
1718
}

genomepy/provider.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ def get_genome_download_link(self, name, mask="soft", **kwargs):
434434

435435
ftp_site = "ftp://ftp.ensemblgenomes.org/pub"
436436
if division == "vertebrates":
437-
ftp_site = "https://ftp.ensembl.org/pub"
437+
ftp_site = "http://ftp.ensembl.org/pub"
438438

439439
version = self.version
440440
if kwargs.get("version", None):
@@ -510,7 +510,7 @@ def download_annotation(self, name, genome_dir, localname=None, **kwargs):
510510
# Get the base link depending on division
511511
ftp_site = "ftp://ftp.ensemblgenomes.org/pub"
512512
if division == "vertebrates":
513-
ftp_site = "https://ftp.ensembl.org/pub"
513+
ftp_site = "http://ftp.ensembl.org/pub"
514514

515515
version = self.version
516516
if kwargs.get("version", None):

tests/test_2_links.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def test_ensemblgenomes_genome_download_links():
3030
"""
3131
p = genomepy.provider.ProviderBase.create("Ensembl")
3232

33-
for genome in ["AgamP4", "WBcel235"]:
33+
for genome in ["Amel_4.5", "WBcel235"]:
3434
p.get_genome_download_link(genome)
3535

3636

0 commit comments

Comments
 (0)