Skip to content

Commit 4f9fc69

Browse files
committed
Sync console application version & add release Makefile
The console application reported a hardcoded version (5.0.0) that drifted from the released git tags, so `./bin/soap-client` printed a stale version (see phpro#611). - Bump APP_VERSION to 6.1.0 to match the latest release. - Add a Makefile `tag` target (modelled on phpro/grumphp) that rewrites APP_VERSION, lints, commits and creates a signed tag without the `v` prefix, keeping the constant and the tag in sync by construction.
1 parent e68eb48 commit 4f9fc69

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

Makefile

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
help:
2+
@echo "Please use \`make <target>' where <target> is one of"
3+
@echo " tag to modify the version and tag"
4+
5+
tag:
6+
$(if $(TAG),,$(error TAG is not defined. Pass via "make tag TAG=6.2.0"))
7+
@echo Tagging $(TAG)
8+
sed -i '' -e "s/APP_VERSION = '.*'/APP_VERSION = '$(TAG)'/" src/Phpro/SoapClient/Console/Application.php
9+
php -l src/Phpro/SoapClient/Console/Application.php
10+
git add -A
11+
git commit -m '$(TAG) release' -n
12+
git tag -s '$(TAG)' -m 'Version $(TAG)'

src/Phpro/SoapClient/Console/Application.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
class Application extends SymfonyApplication
2121
{
2222
const APP_NAME = 'SoapClient';
23-
const APP_VERSION = '5.0.0';
23+
const APP_VERSION = '6.1.0';
2424

2525
/**
2626
* Set up application:

0 commit comments

Comments
 (0)